YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Math.trunc(x) if -1 < x < 0 (#3445)

Browse Source 
Math.trunc(x) should be -0.0 if -1 < x < 0 (ES2015 20.2.2.35). The problem
was that -0 isn't -0.0, but +0.0 in C. There were a test case for it, but
it was incorrect, because +0.0 === -0.0 in JS.

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
This commit is contained in:
Csaba Osztrogonác
2019-12-12 10:57:44 +01:00
committed by Dániel Bátyai
parent df6995d0f6
commit fb4b18a515
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/ecma-builtin-math.c
+2 -2
View File
@@ -177,12 +177,12 @@ ecma_builtin_math_object_trunc (ecma_number_t arg)
if ((arg > 0) && (arg < 1))
{
return (ecma_number_t) 0;
return (ecma_number_t) 0.0;
}
if ((arg < 0) && (arg > -1))
{
return (ecma_number_t) -0;
return (ecma_number_t) -0.0;
}
return (ecma_number_t) arg - fmod (arg, 1);
tests/jerry/es2015/math-trunc.js
+9 -4
View File
@@ -18,13 +18,18 @@ var m_zero = -p_zero;
var p_inf = Infinity;
var m_inf = -p_inf;
function isSameZero (x, y)
{
return x === 0 && (1 / x) === (1 / y);
}
assert (isNaN(Math['trunc'](NaN)));
assert (Math['trunc'](p_zero) === p_zero);
assert (Math['trunc'](m_zero) === m_zero);
assert (isSameZero (Math['trunc'](p_zero), p_zero));
assert (isSameZero (Math['trunc'](m_zero), m_zero));
assert (Math['trunc'](p_inf) === p_inf);
assert (Math['trunc'](m_inf) === m_inf);
assert (Math['trunc'](0.5) === p_zero);
assert (Math['trunc'](-0.5) === m_zero);
assert (isSameZero (Math['trunc'](0.5), p_zero));
assert (isSameZero (Math['trunc'](-0.5), m_zero));
assert (Math['trunc'](1.2) === 1);
assert (Math['trunc'](-1.5) === -1);
assert (Math['trunc'](65.7) === 65);