YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix propery name duplication check in case of empty collection (#4098)

Browse Source 
Fixes: #4093

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
This commit is contained in:
Péter Gál
2020-08-03 17:27:50 +02:00
committed by GitHub
parent cfd69d3b70
commit e9b794f629
3 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/base/ecma-helpers-collection.c
+5
View File
@@ -197,6 +197,11 @@ ecma_collection_append (ecma_collection_t *collection_p, /**< value collection *
bool
ecma_collection_check_duplicated_entries (ecma_collection_t *collection_p) /**< prop name collection */
{
if (collection_p->item_count == 0)
{
return false;
}
ecma_value_t *buffer_p = collection_p->buffer_p;
for (uint32_t i = 0; i < collection_p->item_count - 1; i++)
tests/jerry/es.next/regression-test-issue-4093.js
+25
View File
@@ -0,0 +1,25 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
var v138 = {
ownKeys: function() { return []; },
};
var v140 = new Proxy ({}, v138);
/* expected an empty array */
var result = Object.getOwnPropertyNames (v140);
assert (result instanceof Array);
assert (result.length === 0);
tests/test262-esnext-excludelist.xml
-8
View File
@@ -10445,14 +10445,6 @@
<test id="language/types/reference/get-value-prop-base-primitive-realm.js"><reason></reason></test>
<test id="language/types/reference/put-value-prop-base-primitive-realm.js"><reason></reason></test>
<!-- regression caused by: Rework Object's [[OwnPropertyKeys]] (#4001) -->
<test id="built-ins/Object/getOwnPropertyNames/proxy-invariant-absent-not-configurable-symbol-key.js"><reason></reason></test>
<test id="built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-absent-symbol-key.js"><reason></reason></test>
<test id="built-ins/Object/getOwnPropertySymbols/proxy-invariant-absent-not-configurable-string-key.js"><reason></reason></test>
<test id="built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-absent-string-key.js"><reason></reason></test>
<test id="built-ins/Object/keys/proxy-non-enumerable-prop-invariant-1.js"><reason></reason></test>
<test id="built-ins/Object/keys/proxy-non-enumerable-prop-invariant-2.js"><reason></reason></test>
<!-- regression caused by: Invalid regexp patterns should not throw syntax error during parsing (#4038) -->
<test id="built-ins/RegExp/property-escapes/binary-property-with-value-ASCII_-_F-negated.js"><reason></reason></test>
<test id="built-ins/RegExp/property-escapes/binary-property-with-value-ASCII_-_F.js"><reason></reason></test>