Return early if number conversion is failed in arraybuffer slice. (#2184)

Fixes #2181.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com

jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer-prototype.c

@@ -121,6 +121,11 @@ ecma_builtin_arraybuffer_prototype_object_slice (ecma_value_t this_arg, /**< thi
 
   ECMA_OP_TO_NUMBER_FINALIZE (start_num);
 
+  if (ret_value != ECMA_VALUE_EMPTY)
+  {
+    return ret_value;
+  }
+
   JERRY_ASSERT (start <= len && end <= len);
   ecma_length_t new_len = (end >= start) ? (end - start) : 0;
   ecma_object_t *new_arraybuffer_p = ecma_arraybuffer_new_object (new_len);

tests/jerry/es2015/regression-test-issue-2181.js

@@ -0,0 +1,26 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+var error = {};
+
+try {
+  var arrayBuffer = new ArrayBuffer(1);
+  var start = { valueOf : function ( ) { throw error; } };
+  var end = { valueOf : function ( ) { } };
+
+  arrayBuffer.slice(start, end);
+  assert(false);
+} catch (e) {
+  assert(e === error);
+}