YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correctly handle strict mode in case of Proxy.[[Set]] (#4180)

Browse Source 
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
This commit is contained in:
Péter Gál
2020-09-08 10:03:27 +02:00
committed by GitHub
parent 861bb82749
commit 6f29e48fc6
4 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/operations/ecma-objects.c
+1 -1
View File
@@ -1147,7 +1147,7 @@ ecma_op_object_put_with_receiver (ecma_object_t *object_p, /**< the object */
#if ENABLED (JERRY_BUILTIN_PROXY) #if ENABLED (JERRY_BUILTIN_PROXY)
if (ECMA_OBJECT_IS_PROXY (object_p)) if (ECMA_OBJECT_IS_PROXY (object_p))
{ {
return ecma_proxy_object_set (object_p, property_name_p, value, receiver); return ecma_proxy_object_set (object_p, property_name_p, value, receiver, is_throw);
} }
#endif /* ENABLED (JERRY_BUILTIN_PROXY) */ #endif /* ENABLED (JERRY_BUILTIN_PROXY) */
jerry-core/ecma/operations/ecma-proxy-object.c
+3 -2
View File
@@ -1220,7 +1220,8 @@ ecma_value_t
ecma_proxy_object_set (ecma_object_t *obj_p, /**< proxy object */ ecma_proxy_object_set (ecma_object_t *obj_p, /**< proxy object */
ecma_string_t *prop_name_p, /**< property name */ ecma_string_t *prop_name_p, /**< property name */
ecma_value_t value, /**< value to set */ ecma_value_t value, /**< value to set */
ecma_value_t receiver) /**< receiver to invoke setter function */ ecma_value_t receiver, /**< receiver to invoke setter function */
bool is_strict) /**< indicate strict mode */
{ {
JERRY_ASSERT (ECMA_OBJECT_IS_PROXY (obj_p)); JERRY_ASSERT (ECMA_OBJECT_IS_PROXY (obj_p));
ECMA_CHECK_STACK_USAGE (); ECMA_CHECK_STACK_USAGE ();
@@ -1245,7 +1246,7 @@ ecma_proxy_object_set (ecma_object_t *obj_p, /**< proxy object */
/* 8. */ /* 8. */
if (ecma_is_value_undefined (trap)) if (ecma_is_value_undefined (trap))
{ {
return ecma_op_object_put_with_receiver (target_obj_p, prop_name_p, value, receiver, false); return ecma_op_object_put_with_receiver (target_obj_p, prop_name_p, value, receiver, is_strict);
} }
ecma_object_t *func_obj_p = ecma_get_object_from_value (trap); ecma_object_t *func_obj_p = ecma_get_object_from_value (trap);
jerry-core/ecma/operations/ecma-proxy-object.h
+2 -1
View File
@@ -86,7 +86,8 @@ ecma_value_t
ecma_proxy_object_set (ecma_object_t *obj_p, ecma_proxy_object_set (ecma_object_t *obj_p,
ecma_string_t *prop_name_p, ecma_string_t *prop_name_p,
ecma_value_t name, ecma_value_t name,
ecma_value_t receiver); ecma_value_t receiver,
bool is_strict);
ecma_value_t ecma_value_t
ecma_proxy_object_delete_property (ecma_object_t *obj_p, ecma_proxy_object_delete_property (ecma_object_t *obj_p,
tests/test262-esnext-excludelist.xml
-3
View File
@@ -994,10 +994,7 @@
<test id="built-ins/Proxy/revocable/target-is-revoked-function-proxy.js"><reason></reason></test> <test id="built-ins/Proxy/revocable/target-is-revoked-function-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/revocable/target-is-revoked-proxy.js"><reason></reason></test> <test id="built-ins/Proxy/revocable/target-is-revoked-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/set/call-parameters-prototype-index.js"><reason></reason></test> <test id="built-ins/Proxy/set/call-parameters-prototype-index.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-missing-target-is-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-not-callable-realm.js"><reason></reason></test> <test id="built-ins/Proxy/set/trap-is-not-callable-realm.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-null-target-is-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/set/trap-is-undefined-target-is-proxy.js"><reason></reason></test>
<test id="built-ins/Proxy/setPrototypeOf/toboolean-trap-result-false.js"><reason></reason></test> <test id="built-ins/Proxy/setPrototypeOf/toboolean-trap-result-false.js"><reason></reason></test>
<test id="built-ins/Proxy/setPrototypeOf/trap-is-not-callable-realm.js"><reason></reason></test> <test id="built-ins/Proxy/setPrototypeOf/trap-is-not-callable-realm.js"><reason></reason></test>
<test id="built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u.js"><reason></reason></test> <test id="built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u.js"><reason></reason></test>