From 6f29e48fc6c3f9a578990cbc1d379f004eb667c7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A9ter=20G=C3=A1l?= <pgal.usz@partner.samsung.com>
Date: Tue, 8 Sep 2020 10:03:27 +0200
Subject: [PATCH] Correctly handle strict mode in case of Proxy.[[Set]] (#4180)

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
---
 jerry-core/ecma/operations/ecma-objects.c      | 2 +-
 jerry-core/ecma/operations/ecma-proxy-object.c | 5 +++--
 jerry-core/ecma/operations/ecma-proxy-object.h | 3 ++-
 tests/test262-esnext-excludelist.xml           | 3 ---
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/jerry-core/ecma/operations/ecma-objects.c b/jerry-core/ecma/operations/ecma-objects.c
index d1dbadc4d..c9e6071a2 100644
--- a/jerry-core/ecma/operations/ecma-objects.c
+++ b/jerry-core/ecma/operations/ecma-objects.c
@@ -1147,7 +1147,7 @@ ecma_op_object_put_with_receiver (ecma_object_t *object_p, /**< the object */
 #if ENABLED (JERRY_BUILTIN_PROXY)
   if (ECMA_OBJECT_IS_PROXY (object_p))
   {
-    return ecma_proxy_object_set (object_p, property_name_p, value, receiver);
+    return ecma_proxy_object_set (object_p, property_name_p, value, receiver, is_throw);
   }
 #endif /* ENABLED (JERRY_BUILTIN_PROXY) */
 
diff --git a/jerry-core/ecma/operations/ecma-proxy-object.c b/jerry-core/ecma/operations/ecma-proxy-object.c
index e051a8b12..016cb299d 100644
--- a/jerry-core/ecma/operations/ecma-proxy-object.c
+++ b/jerry-core/ecma/operations/ecma-proxy-object.c
@@ -1220,7 +1220,8 @@ ecma_value_t
 ecma_proxy_object_set (ecma_object_t *obj_p, /**< proxy object */
                        ecma_string_t *prop_name_p, /**< property name */
                        ecma_value_t value, /**< value to set */
-                       ecma_value_t receiver) /**< receiver to invoke setter function */
+                       ecma_value_t receiver, /**< receiver to invoke setter function */
+                       bool is_strict) /**< indicate strict mode */
 {
   JERRY_ASSERT (ECMA_OBJECT_IS_PROXY (obj_p));
   ECMA_CHECK_STACK_USAGE ();
@@ -1245,7 +1246,7 @@ ecma_proxy_object_set (ecma_object_t *obj_p, /**< proxy object */
   /* 8. */
   if (ecma_is_value_undefined (trap))
   {
-    return ecma_op_object_put_with_receiver (target_obj_p, prop_name_p, value, receiver, false);
+    return ecma_op_object_put_with_receiver (target_obj_p, prop_name_p, value, receiver, is_strict);
   }
 
   ecma_object_t *func_obj_p = ecma_get_object_from_value (trap);
diff --git a/jerry-core/ecma/operations/ecma-proxy-object.h b/jerry-core/ecma/operations/ecma-proxy-object.h
index e22075bf2..a428d0ad5 100644
--- a/jerry-core/ecma/operations/ecma-proxy-object.h
+++ b/jerry-core/ecma/operations/ecma-proxy-object.h
@@ -86,7 +86,8 @@ ecma_value_t
 ecma_proxy_object_set (ecma_object_t *obj_p,
                        ecma_string_t *prop_name_p,
                        ecma_value_t name,
-                       ecma_value_t receiver);
+                       ecma_value_t receiver,
+                       bool is_strict);
 
 ecma_value_t
 ecma_proxy_object_delete_property (ecma_object_t *obj_p,
diff --git a/tests/test262-esnext-excludelist.xml b/tests/test262-esnext-excludelist.xml
index a546c8701..a7aab840b 100644
--- a/tests/test262-esnext-excludelist.xml
+++ b/tests/test262-esnext-excludelist.xml
@@ -994,10 +994,7 @@
   <test id="built-ins/Proxy/revocable/target-is-revoked-function-proxy.js"><reason></reason></test>
   <test id="built-ins/Proxy/revocable/target-is-revoked-proxy.js"><reason></reason></test>
   <test id="built-ins/Proxy/set/call-parameters-prototype-index.js"><reason></reason></test>
-  <test id="built-ins/Proxy/set/trap-is-missing-target-is-proxy.js"><reason></reason></test>
   <test id="built-ins/Proxy/set/trap-is-not-callable-realm.js"><reason></reason></test>
-  <test id="built-ins/Proxy/set/trap-is-null-target-is-proxy.js"><reason></reason></test>
-  <test id="built-ins/Proxy/set/trap-is-undefined-target-is-proxy.js"><reason></reason></test>
   <test id="built-ins/Proxy/setPrototypeOf/toboolean-trap-result-false.js"><reason></reason></test>
   <test id="built-ins/Proxy/setPrototypeOf/trap-is-not-callable-realm.js"><reason></reason></test>
   <test id="built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u.js"><reason></reason></test>