YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix attributes of length property for builtin objects (#3556)

Browse Source 
* length property has the attributes {[[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true} based on ECMA-262 v6, 19.2.4.1

JerryScript-DCO-1.0-Signed-off-by: HyukWoo Park hyukwoo.park@samsung.com
This commit is contained in:
Hyukwoo Park
2020-02-14 18:25:26 +09:00
committed by GitHub
parent 4d67ac3225
commit 54e4de39ab
34 changed files with 140 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/base/ecma-globals.h
+9
View File
@@ -398,6 +398,15 @@ typedef enum
*/
#define ECMA_PROPERTY_FIXED 0
/**
* Default flag of length property.
*/
#if ENABLED (JERRY_ES2015)
#define ECMA_PROPERTY_FLAG_DEFAULT_LENGTH ECMA_PROPERTY_FLAG_CONFIGURABLE
#else /* !ENABLED (JERRY_ES2015) */
#define ECMA_PROPERTY_FLAG_DEFAULT_LENGTH ECMA_PROPERTY_FIXED
#endif /* ENABLED (JERRY_ES2015) */
/**
* Shift for property name part.
*/
jerry-core/ecma/builtin-objects/ecma-builtin-array.inc.h
+1 -2
View File
@@ -32,10 +32,9 @@ OBJECT_VALUE (LIT_MAGIC_STRING_PROTOTYPE,
/* Number properties:
* (property name, object pointer getter) */
/* ECMA-262 v5, 15.4.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Routine properties:
* (property name, C routine name, arguments number or NON_FIXED, value of the routine's length property) */
jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer.inc.h
+1 -1
View File
@@ -26,7 +26,7 @@
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-boolean.inc.h
+1 -2
View File
@@ -32,10 +32,9 @@ OBJECT_VALUE (LIT_MAGIC_STRING_PROTOTYPE,
/* Number properties:
* (property name, object pointer getter) */
/* ECMA-262 v5, 15.6.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
#endif /* ENABLED (JERRY_BUILTIN_BOOLEAN) */
jerry-core/ecma/builtin-objects/ecma-builtin-dataview.inc.h
+1 -1
View File
@@ -27,7 +27,7 @@
/* ECMA-262 v6, 23.1.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
3,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ECMA-262 v6, 23.1 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
jerry-core/ecma/builtin-objects/ecma-builtin-date.inc.h
+1 -1
View File
@@ -28,7 +28,7 @@ OBJECT_VALUE (LIT_MAGIC_STRING_PROTOTYPE,
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
7,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
ROUTINE (LIT_MAGIC_STRING_PARSE, ecma_builtin_date_parse, 1, 1)
ROUTINE (LIT_MAGIC_STRING_UTC_U, ecma_builtin_date_utc, NON_FIXED, 7)
jerry-core/ecma/builtin-objects/ecma-builtin-error.inc.h
+1 -2
View File
@@ -22,10 +22,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-evalerror.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-function-prototype.inc.h
+1 -2
View File
@@ -30,10 +30,9 @@ OBJECT_VALUE (LIT_MAGIC_STRING_CONSTRUCTOR,
/* Number properties:
* (property name, object pointer getter) */
/* ECMA-262 v5, 15.3.4 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Routine properties:
* (property name, C routine name, arguments number or NON_FIXED, value of the routine's length property) */
jerry-core/ecma/builtin-objects/ecma-builtin-function.inc.h
+1 -2
View File
@@ -30,9 +30,8 @@ OBJECT_VALUE (LIT_MAGIC_STRING_PROTOTYPE,
/* Number properties:
* (property name, object pointer getter) */
/* ECMA-262 v5, 15.3.3.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
#include "ecma-builtin-helpers-macro-undefs.inc.h"
jerry-core/ecma/builtin-objects/ecma-builtin-generator-function.inc.h
+1 -1
View File
@@ -26,7 +26,7 @@ STRING_VALUE (LIT_MAGIC_STRING_NAME,
LIT_MAGIC_STRING_GENERATOR_FUNCTION_UL,
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ECMA-262 v6, 25.2.2 */
/* ECMA-262 v6, 25.2.2.1 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FLAG_CONFIGURABLE)
jerry-core/ecma/builtin-objects/ecma-builtin-map.inc.h
+1 -1
View File
@@ -27,7 +27,7 @@
/* ECMA-262 v6, 23.1.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ECMA-262 v6, 23.1 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
jerry-core/ecma/builtin-objects/ecma-builtin-number.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.7.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* ECMA-262 v5, 15.7.3.4 */
NUMBER_VALUE (LIT_MAGIC_STRING_NAN,
jerry-core/ecma/builtin-objects/ecma-builtin-object.inc.h
+1 -2
View File
@@ -22,10 +22,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.2.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-promise-prototype.inc.h
-4
View File
@@ -24,10 +24,6 @@ OBJECT_VALUE (LIT_MAGIC_STRING_CONSTRUCTOR,
ECMA_BUILTIN_ID_PROMISE,
ECMA_PROPERTY_CONFIGURABLE_WRITABLE)
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FLAG_WRITABLE)
#if ENABLED (JERRY_ES2015)
/* ECMA-262 v6, 25.4.5.4 */
STRING_VALUE (LIT_GLOBAL_SYMBOL_TO_STRING_TAG,
jerry-core/ecma/builtin-objects/ecma-builtin-promise.inc.h
+1 -1
View File
@@ -26,7 +26,7 @@
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-rangeerror.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-referenceerror.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-regexp.inc.h
+1 -2
View File
@@ -21,10 +21,9 @@
#if ENABLED (JERRY_BUILTIN_REGEXP)
/* ECMA-262 v5, 15.10.5 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
2,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* ECMA-262 v5, 15.10.5.1 */
OBJECT_VALUE (LIT_MAGIC_STRING_PROTOTYPE,
jerry-core/ecma/builtin-objects/ecma-builtin-set.inc.h
+1 -1
View File
@@ -27,7 +27,7 @@
/* ECMA-262 v6, 23.2.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ECMA-262 v6, 23.1 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
jerry-core/ecma/builtin-objects/ecma-builtin-string.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.5.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-symbol-prototype.inc.h
-4
View File
@@ -28,10 +28,6 @@ OBJECT_VALUE (LIT_MAGIC_STRING_CONSTRUCTOR,
ECMA_BUILTIN_ID_SYMBOL,
ECMA_PROPERTY_CONFIGURABLE_WRITABLE)
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FLAG_WRITABLE)
ROUTINE (LIT_MAGIC_STRING_TO_STRING_UL, ecma_builtin_symbol_prototype_object_to_string, 0, 0)
ROUTINE (LIT_MAGIC_STRING_VALUE_OF_UL, ecma_builtin_symbol_prototype_object_value_of, 0, 0)
ROUTINE_CONFIGURABLE_ONLY (LIT_GLOBAL_SYMBOL_TO_PRIMITIVE,
jerry-core/ecma/builtin-objects/ecma-builtin-symbol.inc.h
+1 -1
View File
@@ -27,7 +27,7 @@
/* ECMA-262 v6, 19.4.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-syntaxerror.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-typeerror.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-urierror.inc.h
+1 -2
View File
@@ -24,10 +24,9 @@
/* Number properties:
* (property name, number value, writable, enumerable, configurable) */
/* ECMA-262 v5, 15.11.3 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
1,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_DEFAULT_LENGTH)
/* Object properties:
* (property name, object pointer getter) */
jerry-core/ecma/builtin-objects/ecma-builtin-weakmap.inc.h
+1 -1
View File
@@ -27,7 +27,7 @@
/* ECMA-262 v6, 23.3.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ECMA-262 v6, 23.1 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
jerry-core/ecma/builtin-objects/ecma-builtin-weakset.inc.h
+1 -1
View File
@@ -27,7 +27,7 @@
/* ECMA-262 v6, 23.4.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
0,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ECMA-262 v6, 23.4 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-template.inc.h
+1 -6
View File
@@ -32,18 +32,13 @@
/* ES2015 22.2.5 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
3,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ES2015 22.2.5.1 */
NUMBER_VALUE (LIT_MAGIC_STRING_BYTES_PER_ELEMENT_U,
TYPEDARRAY_BYTES_PER_ELEMENT,
ECMA_PROPERTY_FIXED)
/* ES2015 22.2.5 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
3,
ECMA_PROPERTY_FIXED)
/* ES2015 22.2.5 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
TYPEDARRAY_MAGIC_STRING_ID,
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray.inc.h
+1 -1
View File
@@ -24,7 +24,7 @@
/* ES2015 22.2.2 */
NUMBER_VALUE (LIT_MAGIC_STRING_LENGTH,
3,
ECMA_PROPERTY_FIXED)
ECMA_PROPERTY_FLAG_CONFIGURABLE)
/* ES2015 22.2.2 */
STRING_VALUE (LIT_MAGIC_STRING_NAME,
tests/jerry-test-suite/es2015/25/25.04/25.04.05/25.04.05-001.js
+1 -1
View File
@@ -13,4 +13,4 @@
* limitations under the License.
*/
assert (Promise.prototype.length === 1);
assert (Promise.length === 1);
tests/jerry-test-suite/es51-profile-list
-1
View File
@@ -1110,7 +1110,6 @@
./15/15.03/15.03.03/15.03.03.01/15.03.03.01-002.js
./15/15.03/15.03.03/15.03.03.01/15.03.03.01-003.js
./15/15.03/15.03.03/15.03.03.01/15.03.03.01-004.js
./15/15.03/15.03.03/15.03.03.02/15.03.03.02-001.js
./15/15.03/15.03.04/15.03.04.02/15.03.04.02-001.js
./15/15.03/15.03.04/15.03.04.02/15.03.04.02-002.js
./15/15.03/15.03.04/15.03.04.02/15.03.04.02-003.js
tests/jerry/es2015/length-property.js
+102
View File
@@ -0,0 +1,102 @@
/* Copyright JS Foundation and other contributors, http://js.foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
var builtin_objects = [
Array,
ArrayBuffer,
Boolean,
DataView,
Date,
Error,
EvalError,
Function,
Map,
Number,
Object,
Promise,
RangeError,
ReferenceError,
RegExp,
Set,
String,
Symbol,
SyntaxError,
TypeError,
URIError,
WeakMap,
WeakSet,
];
var builtin_prototypes = [Function.prototype]
var builtin_typedArrays = [
Float32Array,
Float64Array,
Int16Array,
Int32Array,
Int8Array,
Uint16Array,
Uint32Array,
Uint8Array,
Uint8ClampedArray,
];
(function () {
/* each length property is configurable */
var desc;
for (obj of builtin_objects) {
desc = Object.getOwnPropertyDescriptor(obj, 'length');
assert(desc.writable === false);
assert(desc.enumerable === false);
assert(desc.configurable === true);
}
for (proto of builtin_prototypes) {
desc = Object.getOwnPropertyDescriptor(proto, 'length');
assert(desc.writable === false);
assert(desc.enumerable === false);
assert(desc.configurable === true);
}
for (ta of builtin_typedArrays) {
desc = Object.getOwnPropertyDescriptor(ta, 'length');
assert(desc.writable === false);
assert(desc.enumerable === false);
assert(desc.configurable === true);
}
})();
(function () {
/* each length property can be deleted */
for (obj of builtin_objects) {
assert(obj.hasOwnProperty('length') === true);
assert(delete obj.length);
assert(obj.hasOwnProperty('length') === false);
}
for (proto of builtin_prototypes) {
assert(proto.hasOwnProperty('length') === true);
assert(delete proto.length);
assert(proto.hasOwnProperty('length') === false);
}
for (ta of builtin_typedArrays) {
assert(ta.hasOwnProperty('length') === true);
assert(delete ta.length);
assert(ta.hasOwnProperty('length') === false);
}
})();
tests/jerry-test-suite/15/15.03/15.03.03/15.03.03.02/15.03.03.02-001.js → tests/jerry/es5.1/func-length.js
+1 -1
View File
@@ -16,4 +16,4 @@ var desc = Object.getOwnPropertyDescriptor(Function, "length");
assert(desc.value === 1 &&
desc.writable === false &&
desc.enumerable === false &&
desc.configurable === false);
desc.configurable === false);