Updated README, improving some of the section code.

This commit is contained in:
2018-10-30 21:24:39 +11:00
parent 6ace1f03fd
commit c740652a48
7 changed files with 72 additions and 24 deletions

View File

@ -14,9 +14,12 @@ Plans to add are:
- More Social integration and show off my social pages
- Faster loading (SVG Backgrounds are quite large)
- ~~Responsive Image Loading~~
- Async Image/Video loading for content (no point just yet)
- ~~Async Image/Video loading for content (no point just yet)~~
- ~~Async page offsetting,~~ as well as proper loading templates
- Improved SEO
- Reduce Divitis
- Restore previously removed page transitions
- Convert some of the SVGs into responsive PNGs
- ~~Convert some of the SVGs into responsive PNGs~~ Unsure if I'll stick with this permanently
- Work on Async Sections
- Proper Server
- Adjust the order import order so to help CSS Overrides.

View File

@ -41,6 +41,7 @@ export default props => {
import BodySection from './body/BodySection';
import ClearSection from './layout/ClearSection';
import ImageSection from './image/ImageSection';
import BannerImageSection from './image/banner/BannerImageSection';
import SplitSection, { Split } from './layout/SplitSection';
import VideoSection from './video/VideoSection';
@ -48,6 +49,7 @@ export {
BodySection,
ClearSection,
ImageSection,
BannerImageSection,
SplitSection,
Split,
VideoSection

View File

@ -24,7 +24,7 @@
import React from 'react';
import Section from '@components/section/Section';
import BannerImageSection from '@sections/image/banner/BannerImageSection';
import Image from '@objects/image/Image';
import ContentBox from '@objects/content/box/ContentBox';
@ -36,11 +36,11 @@ export default props => {
let { article } = props;
return (
<Section className="c-featured-article">
<Image
src={ require('@assets/images/photo.jpg') }
className="c-featured-article__image"
/>
<BannerImageSection
className="c-featured-article"
src={ require('@assets/images/photo.jpg') } alt={ article.title }
loadable
>
<Title className="c-featured-article__title">
{ article.title }
</Title>
@ -48,6 +48,6 @@ export default props => {
<Paragraph className="c-featured-article__description">
{ article.shortDescription }
</Paragraph>
</Section>
</BannerImageSection>
);
};

View File

@ -0,0 +1,36 @@
// Copyright (c) 2018 Dominic Masters
//
// MIT License
//
// Permission is hereby granted, free of charge, to any person obtaining
// a copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to
// permit persons to whom the Software is furnished to do so, subject to
// the following conditions:
//
// The above copyright notice and this permission notice shall be
// included in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
// LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
// OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
// WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
import React from 'react';
import ImageSection from './../ImageSection';
import Styles from './BannerImageSection.scss';
export default props => {
let { className, imageClassName } = props;
return <ImageSection
{...props} className={`c-banner-section ${className||""}`}
imageClassName={`c-banner-section__image ${imageClassName||""}`}
/>;
};

View File

@ -0,0 +1,18 @@
/*
* Banner Image Section
* Section that adjusts the image to better suit a banner, rather than using
* the annoying image size.
*
* Version:
* 1.0.0 - 2018/10/30
*/
@import '~@styles/global';
.c-banner-section {
&__image {
display: block;
width: 100%;
height: 80vh;
object-fit: cover;
}
}

View File

@ -12,14 +12,6 @@
@import '~@styles/global';
.p-home-page {
&__banner {
&-image {
object-fit: cover;
height: 80vh;
}
}
&__banner,
&__promo {
position: relative;

View File

@ -24,7 +24,7 @@
import React from 'react';
import { withLanguage } from '@public/language/Language';
import { PageBoundary } from '@components/page/Page';
import { ImageSection } from '@components/section/Section';
import { BannerImageSection } from '@sections/Section';
import FloatingContentBox from '@objects/content/box/FloatingContentBox';
import { Title, Subtitle } from '@objects/typography/Typography';
@ -33,14 +33,11 @@ export default withLanguage(props => {
let { lang } = props;
return (
<ImageSection
<BannerImageSection
className="p-home-page__banner"
imageClassName="p-home-page__banner-image"
src={ require('@assets/images/banners/about/glasses.svg') }
alt="domsPlace"
width="2400"
height="1200"
loadable
width="2400" height="1200" loadable
>
<PageBoundary full>
<FloatingContentBox position="middle center" size="large" className="u-text-center">
@ -48,6 +45,6 @@ export default withLanguage(props => {
<Subtitle>{ lang.pages.home.banner.subtitle }</Subtitle>
</FloatingContentBox>
</PageBoundary>
</ImageSection>
</BannerImageSection>
);
});