baddle

battle/BattleScene.gd

@@ -2,9 +2,48 @@ class_name BattleScene extends Node3D
 
 @export var actionBox:ActionBox = null
 
+signal neverEmitted
+
 func _init() ->void:
   BATTLE.battleScene = self
   BATTLE.battleStarted.connect(onBattleStarted)
 
 func onBattleStarted() -> void:
   pass
+
+func getBattleDecisions(fighters:Array[BattleFighter]) -> Array[BattleDecision]:
+  var decisions:Array[BattleDecision] = []
+
+  while fighters.size() > decisions.size():
+    var fighter = fighters[decisions.size()]
+    var decision:BattleDecision = null
+
+    # Simulate walking forward animation like in Final Fantasy
+    await get_tree().create_timer(0.5).timeout
+
+    # Until decision made...
+    while decision == null:
+      # Get the selected action
+      actionBox.visible = true
+      var action = await self.actionBox.getAction(fighter)
+      
+      # Go back to previous fighter
+      if action == ActionBox.Action.BACK:
+        decisions.pop_back()
+        actionBox.visible = false
+        break
+      elif action == ActionBox.Action.ATTACK:
+        var targets = await _getTargets(fighter, fighter.movePrimary)
+
+      actionBox.visible = false
+
+    if decision != null:
+      decisions.append(decision)
+
+  # Return the made decision
+  return decisions
+
+func _getTargets(fighter:BattleFighter, move:BattleAction) -> Array[BattleFighter]:
+  print("Determining target")
+  await neverEmitted
+  return []

battle/action/BattleAction.gd

@@ -1,11 +1,22 @@
 class_name BattleAction
 
 var speedModifier:float
+var canTargetMultiple:bool
+var canTargetEnemy:bool
+var canTargetAlly:bool
+var preferAlly:bool
 
 func _init(params:Dictionary) -> void:
   self.speedModifier = params.get("speedModifier", 1.0)
+  self.canTargetMultiple = params.get("canTargetMultiple", false)
+  self.canTargetEnemy = params.get("canTargetEnemy", true)
+  self.canTargetAlly = params.get("canTargetAlly", true)
+  self.preferAlly = params.get("preferAlly", false)
 
 func perform(params:Dictionary) -> void:
   assert(params.has("user"))
-  assert(params.has("target"))
+  assert(params.has("targets"))
   pass
+
+func canFighterUse(fighter:BattleFighter) -> bool:
+  return true

battle/action/BattleDecision.gd

@@ -2,12 +2,15 @@ class_name BattleDecision
 
 var action:BattleAction
 var user:BattleFighter
-var target:BattleFighter
+var targets:Array[BattleFighter]
 
-func _init(_action:BattleAction, _user:BattleFighter, _target:BattleFighter) -> void:
+func _init(_action:BattleAction, _user:BattleFighter, _targets:Array[BattleFighter]) -> void:
   action = _action
   user = _user
-  target = _target
+  targets = _targets
 
 func getPriority() -> float:
   return 1.0
+
+func execute(cutscene:Cutscene) -> void:
+  pass

battle/action/BattleItem.gd

@@ -11,4 +11,4 @@ func perform(params:Dictionary) -> void:
   super.perform(params)
 
   var user:BattleFighter = params.get("user")
-  var target:BattleFighter = params.get("target")
+  var targets:Array[BattleFighter] = params.get("targets")

battle/action/BattleMove.gd

@@ -32,12 +32,13 @@ func perform(params:Dictionary):
   super.perform(params)
 
   var user:BattleFighter = params.get("user")
-  var target:BattleFighter = params.get("target")
+  var targets:Array[BattleFighter] = params.get("targets")
   
   # What to do if target is dead?
-  if target.status == BattleFighter.Status.DEAD:
+  for target in targets:
-    print("Target is already dead. Move has no effect.")
+    if target.status == BattleFighter.Status.DEAD:
-    assert(false)
+      print("Target is already dead. Move has no effect.")
+      assert(false)
 
   # TODO: Determine damage
   var damage:int = 0
@@ -51,9 +52,19 @@ func perform(params:Dictionary):
   
   if isCrit:
     print("CRITICAL HIT!")
-  target.damage(damage, isCrit)
+  for target in targets:
+    target.damage(damage, isCrit)
   print("DAMAGE DONE")
 
+func canFighterUse(fighter:BattleFighter) -> bool:
+  if !super.canFighterUse(fighter):
+    return false
+  
+  if fighter.mp < self.mpCost:
+    return false
+
+  return true
+
 # Moves
 static var MOVE_PUNCH = BattleMove.new({
   "name": "Punch",
@@ -67,7 +78,8 @@ static var MOVE_FIRE1 = BattleMove.new({
   "power": 25,
   "mpCost": 5,
   "accuracy": 0.9,
-  "moveType": MoveType.MAGICAL
+  "moveType": MoveType.MAGICAL,
+  "canTargetMultiple": true
 })
 
 static var MOVE_HEAL1 = BattleMove.new({
@@ -75,5 +87,7 @@ static var MOVE_HEAL1 = BattleMove.new({
   "power": -20,
   "mpCost": 8,
   "accuracy": 1.0,
-  "moveType": MoveType.ABILITY
+  "moveType": MoveType.ABILITY,
+  "canTargetMultiple": true,
+  "preferAlly": true
 })

battle/fighter/BattleFighter.gd

@@ -6,7 +6,7 @@ enum Status {
 }
 
 enum FighterTeam {
-  PLAYER,
+  ALLY,
   ENEMY
 }
 
@@ -106,4 +106,12 @@ func isPlayerControlled() -> bool:
   return controller == FighterController.PLAYER
 
 func getAIDecision() -> BattleDecision:
+  if !canMakeDecision():
+    return null
   return null
+
+func canMakeDecision() -> bool:
+  return status != Status.DEAD
+
+func canPlayerMakeDecision() -> bool:
+  return isPlayerControlled() && canMakeDecision()

battle/ui/ActionBox.gd

@@ -1,25 +1,40 @@
 class_name ActionBox extends GridContainer
 
+enum Action {
+  ATTACK,
+  MAGIC,
+  ITEM,
+  BACK
+}
+
 @export var btnAttack:Button
 @export var btnMagic:Button
 @export var btnItem:Button
+@export var btnBack:Button
 
-signal decisionMade(move:BattleDecision)
+signal action(action:Action)
 
 func _ready() -> void:
-  btnAttack.pressed.connect(onAttackPressed)
+  btnAttack.pressed.connect(func():
-  btnMagic.pressed.connect(onMagicPressed)
+    action.emit(Action.ATTACK)
-  btnItem.pressed.connect(onItemPressed)
+  )
+  btnMagic.pressed.connect(func():
+    action.emit(Action.MAGIC)
+  )
+  btnItem.pressed.connect(func():
+    action.emit(Action.ITEM)
+  )
+  btnBack.pressed.connect(func():
+    action.emit(Action.BACK)
+  )
   self.visible = false
 
-func onAttackPressed() -> void:
+func getAction(fighter:BattleFighter) -> Action:
-  print("Attack button pressed")
+  btnAttack.disabled = fighter.movePrimary == null || !fighter.movePrimary.canFighterUse(fighter)
-  decisionMade.emit(BattleDecision.new(BattleMove.MOVE_PUNCH, null, null))
+  btnMagic.disabled = fighter.movesMagical.size() == 0
+  btnItem.disabled = false # TODO: check if items available?
   
-func onMagicPressed() -> void:
+  # TODO: Update cursor position to first enabled button
-  print("Magic button pressed")
-  decisionMade.emit(BattleDecision.new(BattleMove.MOVE_FIRE1, null, null))
 
-func onItemPressed() -> void:
+  var act = await action
-  print("Item button pressed")
+  return act
-  decisionMade.emit(null)

battle/ui/ActionBox.tscn

@@ -2,7 +2,7 @@
 
 [ext_resource type="Script" uid="uid://27274005hbgh" path="res://battle/ui/ActionBox.gd" id="1_w5s71"]
 
-[node name="ActionBox" type="GridContainer" node_paths=PackedStringArray("btnAttack", "btnMagic", "btnItem")]
+[node name="ActionBox" type="GridContainer" node_paths=PackedStringArray("btnAttack", "btnMagic", "btnItem", "btnBack")]
 anchors_preset = 3
 anchor_left = 1.0
 anchor_top = 1.0
@@ -17,6 +17,7 @@ script = ExtResource("1_w5s71")
 btnAttack = NodePath("Attack")
 btnMagic = NodePath("Magic")
 btnItem = NodePath("Items")
+btnBack = NodePath("Back")
 metadata/_custom_type_script = "uid://27274005hbgh"
 
 [node name="Attack" type="Button" parent="."]
@@ -31,6 +32,6 @@ text = "Magic"
 layout_mode = 2
 text = "Items"
 
-[node name="idk" type="Button" parent="."]
+[node name="Back" type="Button" parent="."]
 layout_mode = 2
-text = "idk"
+text = "Back"

cutscene/battle/BattleCutsceneAction.gd

@@ -37,29 +37,31 @@ static func playerDecisionCallable(_params:Dictionary) -> int:
     print("All enemies defeated! Victory!")
     assert(false)
 
-  # OK we are actually fighting.
+  # Determine fighters and whether they're AI or player controlled
+  var playerFighters:Array[BattleFighter] = []
+  var aiFighters:Array[BattleFighter] = []
+
+  for fighter:BattleFighter in BATTLE.fighterMap.values():
+    if !fighter || !fighter.canPlayerMakeDecision():
+      continue
+    playerFighters.append(fighter)
+
+  for fighter:BattleFighter in BATTLE.fighterMap.values():
+    if !fighter || !fighter.canMakeDecision():
+      continue
+    if fighter in playerFighters:
+      continue
+    aiFighters.append(fighter)
+
+  # Get decisions
   var decisions:Array[BattleDecision] = []
+  var playerDecisions = await BATTLE.battleScene.getBattleDecisions(playerFighters)
+  decisions.append_array(playerDecisions)
 
-  for fighter:BattleFighter in BATTLE.fighterMap.values():
+  for fighter in aiFighters:
-    if !fighter || !fighter.isPlayerControlled():
-      continue
-
-    # Handle player decision
-    BATTLE.battleScene.actionBox.visible = true
-    var decision = await BATTLE.battleScene.actionBox.decisionMade
-    BATTLE.battleScene.actionBox.visible = false
-    if decision == null:
-      continue
-    decisions.append(decision)
-
-  # AI decisions
-  for fighter:BattleFighter in BATTLE.fighterMap.values():
-    if !fighter || fighter.isPlayerControlled():
-      continue
     var decision = fighter.getAIDecision()
-    if decision == null:
+    if decision != null:
-      continue
+      decisions.append(decision)
-    decisions.append(decision)
 
   # Here I could do something like cutscene specific logic?
 

party/Party.gd

@@ -2,7 +2,7 @@ class_name PartySingleton extends Node
 
 static var PARTY_JOHN = PartyMember.new({
   'name': "John",
-  'team': BattleFighter.FighterTeam.PLAYER,
+  'team': BattleFighter.FighterTeam.ALLY,
   "maxHealth": 9999999999,
   "movePrimary": BattleMove.MOVE_PUNCH,
   "movesMagical": [ BattleMove.MOVE_FIRE1 ],