From ff1a99b999de4795954e1fa8fe5a9f1e56d917f4 Mon Sep 17 00:00:00 2001 From: kisbg Date: Tue, 26 Jan 2021 11:00:45 +0100 Subject: [PATCH] Date.prototype.setTime should return with clipped date (#4520) JerryScript-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu --- jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c | 2 +- jerry-core/ecma/builtin-objects/ecma-builtin-date.c | 4 ++-- tests/test262-esnext-excludelist.xml | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c b/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c index a0375ec56..16dcfb9b3 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c @@ -630,7 +630,7 @@ ecma_builtin_date_prototype_dispatch_routine (uint8_t builtin_routine_id, /**< b *prim_value_p = ecma_date_time_clip (time_num); - return ecma_make_number_value (time_num); + return ecma_make_number_value (*prim_value_p); } if (builtin_routine_id <= ECMA_DATE_PROTOTYPE_SET_UTC_MILLISECONDS) diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-date.c b/jerry-core/ecma/builtin-objects/ecma-builtin-date.c index ccbd79a09..ed28b3664 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-date.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-date.c @@ -769,7 +769,7 @@ ecma_builtin_date_dispatch_construct (const ecma_value_t *arguments_list_p, /**< /* 4.b */ else { - ecma_value_t prim_comp_value = ecma_op_to_primitive (argument, ECMA_PREFERRED_TYPE_NUMBER); + ecma_value_t prim_comp_value = ecma_op_to_primitive (argument, ECMA_PREFERRED_TYPE_NO); if (ECMA_IS_VALUE_ERROR (prim_comp_value)) { @@ -795,7 +795,7 @@ ecma_builtin_date_dispatch_construct (const ecma_value_t *arguments_list_p, /**< else { ecma_number_t arg; - ecma_value_t prim_value = ecma_op_to_number (argument, &arg); + ecma_value_t prim_value = ecma_op_to_number (prim_comp_value, &arg); if (ECMA_IS_VALUE_ERROR (prim_value)) { diff --git a/tests/test262-esnext-excludelist.xml b/tests/test262-esnext-excludelist.xml index 0bcae165a..f38fbedfe 100644 --- a/tests/test262-esnext-excludelist.xml +++ b/tests/test262-esnext-excludelist.xml @@ -33,12 +33,9 @@ - - -