From fc3cfc4fdc1e3f0b245eca24b6a3778f05704f35 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Mon, 4 Nov 2019 12:12:01 +0100 Subject: [PATCH] Arrow functions "prototype" property should not be lazy listed (#3268) This patch fixes #3267. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- .../ecma/operations/ecma-function-object.c | 10 ++++----- .../es2015/regression-test-issue-3267.js | 22 +++++++++++++++++++ 2 files changed, 27 insertions(+), 5 deletions(-) create mode 100644 tests/jerry/es2015/regression-test-issue-3267.js diff --git a/jerry-core/ecma/operations/ecma-function-object.c b/jerry-core/ecma/operations/ecma-function-object.c index e2e8871f0..41b8996cc 100644 --- a/jerry-core/ecma/operations/ecma-function-object.c +++ b/jerry-core/ecma/operations/ecma-function-object.c @@ -1437,9 +1437,6 @@ ecma_op_function_list_lazy_property_names (ecma_object_t *object_p, /**< functio /* 'length' property is non-enumerable (ECMA-262 v5, 13.2.5) */ ecma_collection_push_back (for_non_enumerable_p, ecma_make_magic_string_value (LIT_MAGIC_STRING_LENGTH)); - /* 'prototype' property is non-enumerable (ECMA-262 v5, 13.2.18) */ - ecma_collection_push_back (for_non_enumerable_p, ecma_make_magic_string_value (LIT_MAGIC_STRING_PROTOTYPE)); - const ecma_compiled_code_t *bytecode_data_p; #if ENABLED (JERRY_ES2015) @@ -1449,10 +1446,13 @@ ecma_op_function_list_lazy_property_names (ecma_object_t *object_p, /**< functio } else { +#endif /* ENABLED (JERRY_ES2015) */ bytecode_data_p = ecma_op_function_get_compiled_code ((ecma_extended_object_t *) object_p); + + /* 'prototype' property is non-enumerable (ECMA-262 v5, 13.2.18) */ + ecma_collection_push_back (for_non_enumerable_p, ecma_make_magic_string_value (LIT_MAGIC_STRING_PROTOTYPE)); +#if ENABLED (JERRY_ES2015) } -#else /* ENABLED (JERRY_ES2015) */ - bytecode_data_p = ecma_op_function_get_compiled_code ((ecma_extended_object_t *) object_p); #endif /* ENABLED (JERRY_ES2015) */ if (bytecode_data_p->status_flags & CBC_CODE_FLAGS_STRICT_MODE) diff --git a/tests/jerry/es2015/regression-test-issue-3267.js b/tests/jerry/es2015/regression-test-issue-3267.js new file mode 100644 index 000000000..3e574fdb9 --- /dev/null +++ b/tests/jerry/es2015/regression-test-issue-3267.js @@ -0,0 +1,22 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +var hasProp = $ => { } +Object.preventExtensions(hasProp); +assert (Object.isSealed(hasProp)); + +var keys = Object.getOwnPropertyNames(hasProp); +assert (keys.length === 1); +assert (keys[0] === "length"); +