From f6b99b60d27302bba84203fe787beca25ddd2a31 Mon Sep 17 00:00:00 2001 From: Akos Kiss Date: Thu, 9 Aug 2018 10:11:25 +0200 Subject: [PATCH] Reduce the scope of variable `str_buf` in jerry-main (#2457) Also reduce the number of magic constants used in the code. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu --- jerry-main/main-unix.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/jerry-main/main-unix.c b/jerry-main/main-unix.c index 152bf4a64..7712cdcb8 100644 --- a/jerry-main/main-unix.c +++ b/jerry-main/main-unix.c @@ -745,14 +745,16 @@ main (int argc, jerry_value_t abort_value = jerry_get_value_from_error (ret_value, false); if (jerry_value_is_string (abort_value)) { - jerry_char_t str_buf[5]; + static const char restart_str[] = "r353t"; + jerry_value_t str_val = jerry_value_to_string (abort_value); jerry_size_t str_size = jerry_get_string_size (str_val); - if (str_size == 5) + if (str_size == sizeof (restart_str) - 1) { + JERRY_VLA (jerry_char_t, str_buf, str_size); jerry_string_to_char_buffer (str_val, str_buf, str_size); - if (memcmp ("r353t", (char *) (str_buf), 5) == 0) + if (memcmp (restart_str, (char *) (str_buf), str_size) == 0) { jerry_release_value (ret_value); restart = true;