From f5757e4c9161797768aa71ffbedd62131329755d Mon Sep 17 00:00:00 2001
From: Daniel Balla <dballa@inf.u-szeged.hu>
Date: Fri, 31 Aug 2018 16:45:32 +0200
Subject: [PATCH] Fix ecma_builtin_promise_race_or_all function (#2491)

If a new Capability was created no check was issued if it happened to be an error.
Fixes #2465
Fixes #2468
Also fixes the second variant of #2490.

JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu
---
 .../ecma/builtin-objects/ecma-builtin-promise.c  |  6 ++++++
 tests/jerry/fail/regression-test-issue-2465.js   | 16 ++++++++++++++++
 tests/jerry/fail/regression-test-issue-2468.js   | 16 ++++++++++++++++
 .../fail/regression-test-issue-2490-variant2.js  | 16 ++++++++++++++++
 4 files changed, 54 insertions(+)
 create mode 100644 tests/jerry/fail/regression-test-issue-2465.js
 create mode 100644 tests/jerry/fail/regression-test-issue-2468.js
 create mode 100644 tests/jerry/fail/regression-test-issue-2490-variant2.js

diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c b/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
index 274ded39c..98c19f05a 100644
--- a/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
+++ b/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
@@ -558,6 +558,12 @@ ecma_builtin_promise_race_or_all (ecma_value_t this_arg, /**< 'this' argument */
   }
 
   ecma_value_t capability = ecma_promise_new_capability ();
+
+  if (ECMA_IS_VALUE_ERROR (capability))
+  {
+    return capability;
+  }
+
   ecma_value_t ret = ECMA_VALUE_EMPTY;
 
   if (!ecma_is_value_object (array)
diff --git a/tests/jerry/fail/regression-test-issue-2465.js b/tests/jerry/fail/regression-test-issue-2465.js
new file mode 100644
index 000000000..32ac02aed
--- /dev/null
+++ b/tests/jerry/fail/regression-test-issue-2465.js
@@ -0,0 +1,16 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+Object.prototype[1] = 0;
+Promise.all();
diff --git a/tests/jerry/fail/regression-test-issue-2468.js b/tests/jerry/fail/regression-test-issue-2468.js
new file mode 100644
index 000000000..c1db62a02
--- /dev/null
+++ b/tests/jerry/fail/regression-test-issue-2468.js
@@ -0,0 +1,16 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+Object.prototype[1] = 0;
+Promise.race([]);
diff --git a/tests/jerry/fail/regression-test-issue-2490-variant2.js b/tests/jerry/fail/regression-test-issue-2490-variant2.js
new file mode 100644
index 000000000..d0175e2f6
--- /dev/null
+++ b/tests/jerry/fail/regression-test-issue-2490-variant2.js
@@ -0,0 +1,16 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+Object.defineProperty(Object.prototype, 2, {});
+Promise.all([0]);