Fix evaluation order for binary operators (#4114)

Furthermore fix toBoolean for BigInts as well.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com

tests/jerry/es.next/arithmetics-3.js

@@ -0,0 +1,37 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+var o1 = { valueOf() { return Symbol() } }
+var o2 = { valueOf() { throw "Should not reach here" } }
+
+function check_type_error(code) {
+  try {
+    eval(code)
+    assert(false)
+  } catch (e) {
+    assert(e instanceof TypeError)
+  }
+}
+
+check_type_error("o1 - o2")
+check_type_error("o1 * o2")
+check_type_error("o1 / o2")
+check_type_error("o1 % o2")
+check_type_error("o1 ** o2")
+check_type_error("o1 | o2")
+check_type_error("o1 & o2")
+check_type_error("o1 ^ o2")
+check_type_error("o1 << o2")
+check_type_error("o1 >> o2")
+check_type_error("o1 >>> o2")

tests/jerry/es.next/bigint4.js

@@ -13,6 +13,12 @@
  * limitations under the License.
  */
 
+/* Boolean. */
+
+assert(!BigInt("0") === true)
+assert(!BigInt("1") === false)
+assert(!BigInt("-1") === false)
+
 /* Strict equal. */
 
 assert(BigInt("0") === BigInt("0"))

tests/test262-esnext-excludelist.xml

@@ -6682,7 +6682,6 @@
   <test id="language/expressions/logical-assignment/lgcl-or-assignment-operator-unresolved-rhs.js"><reason></reason></test>
   <test id="language/expressions/logical-assignment/lgcl-or-assignment-operator.js"><reason></reason></test>
   <test id="language/expressions/logical-assignment/lgcl-or-whitespace.js"><reason></reason></test>
-  <test id="language/expressions/logical-not/bigint.js"><reason></reason></test>
   <test id="language/expressions/logical-or/tco-right.js"><reason></reason></test>
   <test id="language/expressions/new/non-ctor-err-realm.js"><reason></reason></test>
   <test id="language/expressions/new/spread-obj-spread-order.js"><reason></reason></test>
@@ -10468,17 +10467,4 @@
   <test id="language/literals/regexp/u-unicode-esc-bounds.js"><reason></reason></test>
   <test id="language/literals/regexp/u-unicode-esc-non-hex.js"><reason></reason></test>
   <test id="language/literals/regexp/unicode-escape-nls-err.js"><reason></reason></test>
-
-  <!-- regression caused by: Implement BigInt primitve type and some of its operations (#4062) -->
-  <test id="language/expressions/bitwise-and/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/bitwise-or/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/bitwise-xor/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/division/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/exponentiation/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/left-shift/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/modulus/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/multiplication/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/right-shift/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/subtraction/order-of-evaluation.js"><reason></reason></test>
-  <test id="language/expressions/unsigned-right-shift/order-of-evaluation.js"><reason></reason></test>
 </excludeList>