From f02de7a31f23009066adf1945322595d7a8efb35 Mon Sep 17 00:00:00 2001
From: Robert Fancsik <frobert@inf.u-szeged.hu>
Date: Mon, 14 Jan 2019 23:46:01 +0100
Subject: [PATCH] Add missing error check in ecma_builtin_promise_do_all
 (#2694)

This patch fixes #2693.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
---
 .../ecma/builtin-objects/ecma-builtin-promise.c  |  8 ++++++++
 tests/jerry/es2015/regression-test-issue-2693.js | 16 ++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 tests/jerry/es2015/regression-test-issue-2693.js

diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c b/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
index eb93270b6..83b7fe182 100644
--- a/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
+++ b/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c
@@ -470,6 +470,14 @@ ecma_builtin_promise_do_all (ecma_value_t array, /**< the array for all */
     /* e. h. */
     ecma_string_t *index_to_str_p = ecma_new_ecma_string_from_uint32 (index);
     ecma_value_t array_item = ecma_op_object_get (array_p, index_to_str_p);
+
+    if (ECMA_IS_VALUE_ERROR (array_item))
+    {
+      ecma_deref_ecma_string (index_to_str_p);
+      ret = array_item;
+      break;
+    }
+
     ecma_value_t put_ret = ecma_op_object_put (ecma_get_object_from_value (value_array),
                                                index_to_str_p,
                                                undefined_val,
diff --git a/tests/jerry/es2015/regression-test-issue-2693.js b/tests/jerry/es2015/regression-test-issue-2693.js
new file mode 100644
index 000000000..1b7e4416a
--- /dev/null
+++ b/tests/jerry/es2015/regression-test-issue-2693.js
@@ -0,0 +1,16 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+Object.defineProperty(Array.prototype, 0, { get : function ( ) { throw $ } });
+Promise.all([,]);