Regexp.prototype.exec should not generate return array with [[Put]]

Releated issue: #1078

JerryScript-DCO-1.0-Signed-off-by: Youngil Choi duddlf.choi@samsung.com
This commit is contained in:
Youngil Choi
2016-08-22 15:41:28 +09:00
committed by Eunji Jeong
parent 314e74f8ce
commit efdf91a0d6
3 changed files with 26 additions and 18 deletions
@@ -1434,15 +1434,13 @@ ecma_regexp_exec_helper (ecma_value_t regexp_value, /**< RegExp object */
capture_value = ecma_make_string_value (capture_str_p);
}
ECMA_TRY_CATCH (put_value,
ecma_op_object_put (result_array_obj_p,
index_str_p,
capture_value,
true),
ret_value);
ECMA_FINALIZE (put_value);
ecma_property_t *prop_p;
prop_p = ecma_create_named_data_property (result_array_obj_p,
index_str_p,
ECMA_PROPERTY_CONFIGURABLE_ENUMERABLE_WRITABLE);
ecma_set_named_data_property_value (prop_p, capture_value);
ecma_free_value (capture_value);
JERRY_ASSERT (!ecma_is_value_object (capture_value));
ecma_deref_ecma_string (index_str_p);
}
+19
View File
@@ -0,0 +1,19 @@
// Copyright 2016 Samsung Electronics Co., Ltd.
// Copyright 2016 University of Szeged.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Array.prototype.splice(Function.prototype, 1, this);
Object.freeze(Array.prototype);
var res = (new String("Hello")).split(new RegExp());
assert(res.length == 5);
+1 -10
View File
@@ -15,13 +15,4 @@
Array.prototype.push(Math.sin);
Object.freeze(Array.prototype);
try
{
String.prototype.match(String.prototype);
assert (false);
}
catch (e)
{
assert (e instanceof TypeError);
}
String.prototype.match(String.prototype);