Use binary mode when opening via fopen in the tools (#2371)

In the snapshot tool the files were opened
in text mode. However the snapshot files
are binary files thus it is advised to use the
binary mode when opening the files.

Specifying the binary mode is a must on Windows
platform otherwise the read/write operations
are inserting extra '\r' characters.

To make the tools consitent across OSes all
fopen are now opening files in binary mode.

Also update jerry-libc to accept the 'b'
modifier and add a test case where the JS
file uses CR-LF line endings.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
This commit is contained in:
Péter Gál authored and yichoi committed 2018-06-12 04:38:35 +09:00
1 parent 9ae60a4910
commit efa8850783
5 files changed
+41 -10

No files matched your search

+4 -4
View File
@@ -92,7 +92,7 @@ static size_t
read_file (uint8_t *input_pos_p, /**< next position in the input buffer */
const char *file_name) /**< file name */
{
FILE *file = fopen (file_name, "r");
FILE *file = fopen (file_name, "rb");
if (file == NULL)
{
@@ -331,7 +331,7 @@ process_generate (cli_state_t *cli_state_p, /**< cli state */
size_t snapshot_size = (size_t) jerry_get_number_value (snapshot_result);
jerry_release_value (snapshot_result);
FILE *snapshot_file_p = fopen (output_file_name_p, "w");
FILE *snapshot_file_p = fopen (output_file_name_p, "wb");
if (snapshot_file_p == NULL)
{
jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Error: Unable to write snapshot file: '%s'\n", output_file_name_p);
@@ -357,7 +357,7 @@ process_generate (cli_state_t *cli_state_p, /**< cli state */
return JERRY_STANDALONE_EXIT_CODE_FAIL;
}
FILE *literal_file_p = fopen (save_literals_file_name_p, "w");
FILE *literal_file_p = fopen (save_literals_file_name_p, "wb");
if (literal_file_p == NULL)
{
@@ -486,7 +486,7 @@ process_merge (cli_state_t *cli_state_p, /**< cli state */
return JERRY_STANDALONE_EXIT_CODE_FAIL;
}
FILE *file_p = fopen (output_file_name_p, "w");
FILE *file_p = fopen (output_file_name_p, "wb");
if (file_p != NULL)
{
+1 -1
View File
@@ -36,7 +36,7 @@ static const uint8_t *
read_file (const char *file_name,
size_t *out_size_p)
{
FILE *file = fopen (file_name, "r");
FILE *file = fopen (file_name, "rb");
if (file == NULL)
{
jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Error: failed to open file: %s\n", file_name);
+1 -1
View File
@@ -59,7 +59,7 @@ read_file (const char *file_name,
}
else
{
file = fopen (file_name, "r");
file = fopen (file_name, "rb");
if (file == NULL)
{
jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Error: failed to open file: %s\n", file_name);