YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add support for Symbols when using the 'in' operation (#3202)

Browse Source 
The change adds support for the 'in' operation to handle Symbols.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
This commit is contained in:
Péter Gál
2019-10-07 15:31:06 +02:00
committed by Dániel Bátyai
parent 0f754ff33c
commit eb97860509
2 changed files with 67 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/vm/opcodes-ecma-relational-equality.c
+8 -17
View File
@@ -116,7 +116,9 @@ opfunc_instanceof (ecma_value_t left_value, /**< left value */
/**
* 'in' opcode handler.
*
* See also: ECMA-262 v5, 11.8.7
* See also:
* * ECMA-262 v5, 11.8.7
* * ECAM-262 v6, 12.9.3
*
* @return ecma value
* returned value must be freed with ecma_free_value.
@@ -130,28 +132,17 @@ opfunc_in (ecma_value_t left_value, /**< left value */
return ecma_raise_type_error (ECMA_ERR_MSG ("Expected an object in 'in' check."));
}
bool to_string = !ecma_is_value_string (left_value);
ecma_string_t *property_name_p = ecma_op_to_prop_name (left_value);
if (to_string)
if (JERRY_UNLIKELY (property_name_p == NULL))
{
left_value = ecma_op_to_string (left_value);
if (ECMA_IS_VALUE_ERROR (left_value))
{
return left_value;
}
return ECMA_VALUE_ERROR;
}
ecma_string_t *left_value_prop_name_p = ecma_get_string_from_value (left_value);
ecma_object_t *right_value_obj_p = ecma_get_object_from_value (right_value);
ecma_value_t result = ecma_make_boolean_value (ecma_op_object_has_property (right_value_obj_p,
left_value_prop_name_p));
if (to_string)
{
ecma_free_value (left_value);
}
property_name_p));
ecma_deref_ecma_string (property_name_p);
return result;
} /* opfunc_in */