YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement Symbol.prototype.description (#3995)

Browse Source 
The algorithm is based on ECMA-262 v11, 19.4.3.2

Also added a custom dispatcher for the Symbol prototype

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
This commit is contained in:
Szilagyi Adam
2020-07-20 13:47:25 +02:00
committed by GitHub
parent 74781c28c2
commit e8c5c46894
7 changed files with 149 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/operations/ecma-symbol-object.c
+13 -13
View File
@@ -137,42 +137,42 @@ ecma_get_symbol_descriptive_string (ecma_value_t symbol_value) /**< symbol to st
} /* ecma_get_symbol_descriptive_string */
/**
* Helper for Symbol.prototype.{toString, valueOf} routines
* thisSymbolValue abstract operation
*
* See also: 19.4.3.2, 19.4.3.3
* See also:
* ECMA-262 v11, 19.4.3
*
* @return ecma value
* Returned value must be freed with ecma_free_value.
*/
ecma_value_t
ecma_symbol_to_string_helper (ecma_value_t this_arg, /**< this argument value */
bool is_to_string) /**< true - perform the 'toString' routine steps
* false - perform the 'valueOf' routine steps */
ecma_symbol_this_value (ecma_value_t this_arg) /**< this argument value */
{
/* 1. */
if (ecma_is_value_symbol (this_arg))
{
return is_to_string ? ecma_get_symbol_descriptive_string (this_arg) : ecma_copy_value (this_arg);
return this_arg;
}
/* 2. */
if (ecma_is_value_object (this_arg))
{
ecma_object_t *object_p = ecma_get_object_from_value (this_arg);
if (ecma_get_object_type (object_p) == ECMA_OBJECT_TYPE_CLASS)
{
ecma_extended_object_t *ext_object_p = (ecma_extended_object_t *) object_p;
ecma_extended_object_t *ext_obj_p = (ecma_extended_object_t *) object_p;
if (ext_object_p->u.class_prop.class_id == LIT_MAGIC_STRING_SYMBOL_UL)
if (ext_obj_p->u.class_prop.class_id == LIT_MAGIC_STRING_SYMBOL_UL)
{
return (is_to_string ? ecma_get_symbol_descriptive_string (ext_object_p->u.class_prop.u.value)
: ecma_copy_value (ext_object_p->u.class_prop.u.value));
return ext_obj_p->u.class_prop.u.value;
}
}
}
return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' is must be a Symbol."));
} /* ecma_symbol_to_string_helper */
/* 3. */
return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' must be a Symbol."));
} /* ecma_symbol_this_value */
#endif /* ENABLED (JERRY_ESNEXT) */
/**
jerry-core/ecma/operations/ecma-symbol-object.h
+1 -1
View File
@@ -39,7 +39,7 @@ ecma_string_t *
ecma_get_symbol_description (ecma_string_t *symbol_p);
ecma_value_t
ecma_symbol_to_string_helper (ecma_value_t this_arg, bool is_to_string);
ecma_symbol_this_value (ecma_value_t this_arg);
ecma_value_t
ecma_get_symbol_descriptive_string (ecma_value_t symbol_value);