YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rework external string free operation (#4690)

Browse Source 
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
This commit is contained in:
Zoltan Herczeg
2021-08-17 08:31:30 +02:00
committed by GitHub
parent 74e5ccd434
commit e7ffb70ae0
9 changed files with 187 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit-core/test-external-string.c
+37 -16
View File
@@ -25,25 +25,37 @@ static const char *external_3 = "x!?:s";
static const char *external_4 = "Object property external string! Object property external string!";
static void
free_external1 (void *ptr)
external_string_free_callback_1 (jerry_char_t *string_p, /**< string pointer */
jerry_size_t string_size, /**< size of the string */
void *user_p) /**< user pointer */
{
TEST_ASSERT (ptr == external_1);
TEST_ASSERT ((const char *) string_p == external_1);
TEST_ASSERT (string_size == strlen (external_1));
TEST_ASSERT (user_p == NULL);
free_count++;
} /* free_external1 */
} /* external_string_free_callback_1 */
static void
free_external2 (void *ptr)
external_string_free_callback_2 (jerry_char_t *string_p, /**< string pointer */
jerry_size_t string_size, /**< size of the string */
void *user_p) /**< user pointer */
{
TEST_ASSERT (ptr == external_2);
TEST_ASSERT ((const char *) string_p == external_2);
TEST_ASSERT (string_size == strlen (external_2));
TEST_ASSERT (user_p == (void *) &free_count);
free_count++;
} /* free_external2 */
} /* external_string_free_callback_2 */
static void
free_external3 (void *ptr)
external_string_free_callback_3 (jerry_char_t *string_p, /**< string pointer */
jerry_size_t string_size, /**< size of the string */
void *user_p) /**< user pointer */
{
TEST_ASSERT (ptr == external_3);
TEST_ASSERT ((const char *) string_p == external_3);
TEST_ASSERT (string_size == strlen (external_3));
TEST_ASSERT (user_p == (void *) string_p);
free_count++;
} /* free_external3 */
} /* external_string_free_callback_3 */
int
main (void)
@@ -53,38 +65,45 @@ main (void)
jerry_init (JERRY_INIT_EMPTY);
/* Test external callback calls. */
jerry_value_t external_string = jerry_create_external_string ((jerry_char_t *) external_1, free_external1);
jerry_string_set_external_string_free_callback (external_string_free_callback_1);
jerry_value_t external_string = jerry_create_external_string ((jerry_char_t *) external_1, NULL);
TEST_ASSERT (free_count == 0);
jerry_release_value (external_string);
TEST_ASSERT (free_count == 1);
jerry_string_set_external_string_free_callback (NULL);
external_string = jerry_create_external_string ((jerry_char_t *) external_1, NULL);
TEST_ASSERT (free_count == 1);
jerry_release_value (external_string);
TEST_ASSERT (free_count == 1);
external_string = jerry_create_external_string ((jerry_char_t *) external_2, free_external2);
jerry_string_set_external_string_free_callback (external_string_free_callback_2);
external_string = jerry_create_external_string ((jerry_char_t *) external_2, (void *) &free_count);
TEST_ASSERT (free_count == 2);
jerry_release_value (external_string);
TEST_ASSERT (free_count == 2);
external_string = jerry_create_external_string ((jerry_char_t *) external_2, NULL);
jerry_string_set_external_string_free_callback (NULL);
external_string = jerry_create_external_string ((jerry_char_t *) external_2, (void *) &free_count);
TEST_ASSERT (free_count == 2);
jerry_release_value (external_string);
TEST_ASSERT (free_count == 2);
external_string = jerry_create_external_string ((jerry_char_t *) external_3, free_external3);
jerry_string_set_external_string_free_callback (external_string_free_callback_3);
external_string = jerry_create_external_string ((jerry_char_t *) external_3, (void *) external_3);
TEST_ASSERT (free_count == 3);
jerry_release_value (external_string);
TEST_ASSERT (free_count == 3);
external_string = jerry_create_external_string ((jerry_char_t *) external_3, NULL);
jerry_string_set_external_string_free_callback (NULL);
external_string = jerry_create_external_string ((jerry_char_t *) external_3, (void *) external_3);
TEST_ASSERT (free_count == 3);
jerry_release_value (external_string);
TEST_ASSERT (free_count == 3);
/* Test string comparison. */
external_string = jerry_create_external_string ((jerry_char_t *) external_1, free_external1);
jerry_string_set_external_string_free_callback (external_string_free_callback_1);
external_string = jerry_create_external_string ((jerry_char_t *) external_1, NULL);
jerry_value_t other_string = jerry_create_string ((jerry_char_t *) external_1);
jerry_value_t result = jerry_binary_operation (JERRY_BIN_OP_STRICT_EQUAL, external_string, other_string);
@@ -103,7 +122,8 @@ main (void)
jerry_release_value (other_string);
/* Test getting string. */
external_string = jerry_create_external_string ((jerry_char_t *) external_1, free_external1);
jerry_string_set_external_string_free_callback (external_string_free_callback_1);
external_string = jerry_create_external_string ((jerry_char_t *) external_1, NULL);
size_t length = strlen (external_1);
TEST_ASSERT (jerry_value_is_string (external_string));
@@ -119,6 +139,7 @@ main (void)
TEST_ASSERT (free_count == 5);
/* Test property access. */
jerry_string_set_external_string_free_callback (NULL);
external_string = jerry_create_external_string ((jerry_char_t *) external_4, NULL);
other_string = jerry_create_string ((jerry_char_t *) external_4);