Improvements for ecma_op_general_object_define_own_property.

List of improvements:
 - Get the [[Enumerable]] and [[Configurable]] attributes before removing a property.
 - Directly check the type of the property in asserts.

Related issues: #115 and #132

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
This commit is contained in:
Peter Gal
2015-06-02 16:39:25 +02:00
parent d6fb76416a
commit e4db5aa539
3 changed files with 72 additions and 8 deletions
+19
View File
@@ -0,0 +1,19 @@
// Copyright 2015 Samsung Electronics Co., Ltd.
// Copyright 2015 University of Szeged.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
var v_1 = [,];
Object.defineProperty(v_1, "0", {
set: function() {},
});
+42
View File
@@ -0,0 +1,42 @@
// Copyright 2015 Samsung Electronics Co., Ltd.
// Copyright 2015 University of Szeged.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Test raised by fuzzer
v_0 = [,];
v_1 = [,];
v_2 = Object.defineProperties([,], { '0': { get: function() { } } });
// Test change from data to accessor type
var a = { x:2 };
Object.defineProperty(a, "x", {
enumerable: true,
configurable: true,
get: function() { return 0; }
});
// Test change from accessor to data type
var obj = {test: 2};
Object.defineProperty(obj, "test", {
enumerable: true,
configurable: true,
get: function() { return 0; }
});
Object.defineProperty(obj, "x", {
enumerable: true,
configurable: true,
value: -2
});