YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make run-test-suite.py handle crashes properly (#3512)

Browse Source 
Changes:
- Crashing jerry / jerry-snapshot is always "FAIL",
only the 1 return code is accepted as expected fail.
- "FAIL (XPASS)" string is only used if the test marked
as expected fail, but the return code is 0.
- Simple "FAIL" string is used if the test marked as expected
fail, but the return code is not 0 or 1. (crash)

JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
This commit is contained in:
Csaba Osztrogonác
2020-01-15 09:14:51 +01:00
committed by Robert Fancsik
parent 210b631b21
commit e3decffdd3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/runners/run-test-suite.py
+5 -5
View File
@@ -138,13 +138,13 @@ def run_normal_tests(args, tests):
is_expected_to_fail = os.path.join(os.path.sep, 'fail', '') in test is_expected_to_fail = os.path.join(os.path.sep, 'fail', '') in test
(returncode, stdout) = execute_test_command(test_cmd + [test]) (returncode, stdout) = execute_test_command(test_cmd + [test])
if bool(returncode) == is_expected_to_fail: if (returncode == 0 and not is_expected_to_fail) or (returncode == 1 and is_expected_to_fail):
passed += 1 passed += 1
if not args.quiet: if not args.quiet:
passed_string = 'PASS' + (' (XFAIL)' if is_expected_to_fail else '') passed_string = 'PASS' + (' (XFAIL)' if is_expected_to_fail else '')
util.print_test_result(tested, total, True, passed_string, test_path) util.print_test_result(tested, total, True, passed_string, test_path)
else: else:
passed_string = 'FAIL%s (%d)' % (' (XPASS)' if is_expected_to_fail else '', returncode) passed_string = 'FAIL%s (%d)' % (' (XPASS)' if returncode == 0 and is_expected_to_fail else '', returncode)
util.print_test_result(tested, total, False, passed_string, test_path) util.print_test_result(tested, total, False, passed_string, test_path)
print("================================================") print("================================================")
print(stdout) print(stdout)
@@ -176,7 +176,7 @@ def run_snapshot_tests(args, tests):
is_expected_to_fail = os.path.join(os.path.sep, 'fail', '') in test is_expected_to_fail = os.path.join(os.path.sep, 'fail', '') in test
(returncode, stdout) = execute_test_command(generate_snapshot_cmd + [test]) (returncode, stdout) = execute_test_command(generate_snapshot_cmd + [test])
if is_expected_to_fail or not returncode: if (returncode == 0) or (returncode == 1 and is_expected_to_fail):
if not args.quiet: if not args.quiet:
passed_string = 'PASS' + (' (XFAIL)' if returncode else '') passed_string = 'PASS' + (' (XFAIL)' if returncode else '')
util.print_test_result(tested, total, True, passed_string, test_path, True) util.print_test_result(tested, total, True, passed_string, test_path, True)
@@ -194,13 +194,13 @@ def run_snapshot_tests(args, tests):
(returncode, stdout) = execute_test_command(execute_snapshot_cmd) (returncode, stdout) = execute_test_command(execute_snapshot_cmd)
os.remove('js.snapshot') os.remove('js.snapshot')
if bool(returncode) == is_expected_to_fail: if (returncode == 0 and not is_expected_to_fail) or (returncode == 1 and is_expected_to_fail):
passed += 1 passed += 1
if not args.quiet: if not args.quiet:
passed_string = 'PASS' + (' (XFAIL)' if is_expected_to_fail else '') passed_string = 'PASS' + (' (XFAIL)' if is_expected_to_fail else '')
util.print_test_result(tested, total, True, passed_string, test_path, False) util.print_test_result(tested, total, True, passed_string, test_path, False)
else: else:
passed_string = 'FAIL%s (%d)' % (' (XPASS)' if is_expected_to_fail else '', returncode) passed_string = 'FAIL%s (%d)' % (' (XPASS)' if returncode == 0 and is_expected_to_fail else '', returncode)
util.print_test_result(tested, total, False, passed_string, test_path, False) util.print_test_result(tested, total, False, passed_string, test_path, False)
print("================================================") print("================================================")
print(stdout) print(stdout)