Eliminate TODO and FIXME macros
Those macros are legacy and are not used consitently throughout the code base. This patch eliminates their definitions and rewrites their remaining occurrences to TODO comments. All occurrences have been checked and made sure that the comments used a consistent style. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
This commit is contained in:
@@ -359,7 +359,7 @@ lit_char_to_lower_case (ecma_char_t character, /**< input character value */
|
||||
ecma_char_t *output_buffer_p, /**< [out] buffer for the result characters */
|
||||
ecma_length_t buffer_size) /**< buffer size */
|
||||
{
|
||||
TODO ("Needs a proper lower case implementation. See issue #323.");
|
||||
/* TODO: Needs a proper lower case implementation. See issue #323. */
|
||||
|
||||
JERRY_ASSERT (buffer_size >= LIT_MAXIMUM_OTHER_CASE_LENGTH);
|
||||
|
||||
@@ -393,7 +393,7 @@ lit_char_to_upper_case (ecma_char_t character, /**< input character value */
|
||||
ecma_char_t *output_buffer_p, /**< buffer for the result characters */
|
||||
ecma_length_t buffer_size) /**< buffer size */
|
||||
{
|
||||
TODO ("Needs a proper upper case implementation. See issue #323.");
|
||||
/* TODO: Needs a proper upper case implementation. See issue #323. */
|
||||
|
||||
JERRY_ASSERT (buffer_size >= LIT_MAXIMUM_OTHER_CASE_LENGTH);
|
||||
|
||||
|
||||
@@ -205,7 +205,7 @@ lit_dump_literals ()
|
||||
char *str = (char *) (record_p + 1);
|
||||
for (i = 0; i < record_p->size; ++i, ++str)
|
||||
{
|
||||
FIXME ("Support proper printing of characters which occupy more than one byte.")
|
||||
/* TODO: Support proper printing of characters which occupy more than one byte. */
|
||||
|
||||
JERRY_DLOG ("%c", *str);
|
||||
}
|
||||
|
||||
@@ -162,7 +162,7 @@ lit_is_utf8_string_magic (const lit_utf8_byte_t *string_p, /**< utf-8 string */
|
||||
lit_utf8_size_t string_size, /**< string size in bytes */
|
||||
lit_magic_string_id_t *out_id_p) /**< [out] magic string's id */
|
||||
{
|
||||
TODO (Improve performance of search);
|
||||
/* TODO: Improve performance of search */
|
||||
|
||||
for (lit_magic_string_id_t id = (lit_magic_string_id_t) 0;
|
||||
id < LIT_MAGIC_STRING__COUNT;
|
||||
@@ -192,7 +192,7 @@ bool lit_is_ex_utf8_string_magic (const lit_utf8_byte_t *string_p, /**< utf-8 st
|
||||
lit_utf8_size_t string_size, /**< string size in bytes */
|
||||
lit_magic_string_ex_id_t *out_id_p) /**< [out] magic string's id */
|
||||
{
|
||||
TODO (Improve performance of search);
|
||||
/* TODO: Improve performance of search */
|
||||
|
||||
for (lit_magic_string_ex_id_t id = (lit_magic_string_ex_id_t) 0;
|
||||
id < lit_magic_string_ex_count;
|
||||
|
||||
@@ -340,10 +340,7 @@ lit_load_literals_from_snapshot (const uint8_t *lit_table_p, /**< buffer with li
|
||||
const lit_utf8_byte_t *magic_str_p = lit_get_magic_string_utf8 (id);
|
||||
lit_utf8_size_t magic_str_sz = lit_get_magic_string_size (id);
|
||||
|
||||
/*
|
||||
* TODO:
|
||||
* Consider searching literal storage by magic string identifier instead of by its value
|
||||
*/
|
||||
/* TODO: Consider searching literal storage by magic string identifier instead of by its value */
|
||||
lit = (lit_literal_t) lit_find_or_create_literal_from_utf8_string (magic_str_p, magic_str_sz);
|
||||
}
|
||||
else if (type == LIT_RECORD_TYPE_MAGIC_STR_EX)
|
||||
@@ -362,10 +359,7 @@ lit_load_literals_from_snapshot (const uint8_t *lit_table_p, /**< buffer with li
|
||||
const lit_utf8_byte_t *magic_str_ex_p = lit_get_magic_string_ex_utf8 (id);
|
||||
lit_utf8_size_t magic_str_ex_sz = lit_get_magic_string_ex_size (id);
|
||||
|
||||
/*
|
||||
* TODO:
|
||||
* Consider searching literal storage by magic string identifier instead of by its value
|
||||
*/
|
||||
/* TODO: Consider searching literal storage by magic string identifier instead of by its value */
|
||||
lit = (lit_literal_t) lit_find_or_create_literal_from_utf8_string (magic_str_ex_p, magic_str_ex_sz);
|
||||
}
|
||||
else if (type == LIT_RECORD_TYPE_NUMBER)
|
||||
|
||||
@@ -1013,7 +1013,7 @@ lit_put_ecma_char (ecma_char_t ecma_char) /**< code unit */
|
||||
}
|
||||
else
|
||||
{
|
||||
FIXME ("Support unicode characters printing.");
|
||||
/* TODO: Support unicode characters printing. */
|
||||
jerry_port_putchar ('_');
|
||||
}
|
||||
} /* lit_put_ecma_char */
|
||||
|
||||
Reference in New Issue
Block a user