Eliminate TODO and FIXME macros
Those macros are legacy and are not used consitently throughout the code base. This patch eliminates their definitions and rewrites their remaining occurrences to TODO comments. All occurrences have been checked and made sure that the comments used a consistent style. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
This commit is contained in:
1 parent
3127b9d34d
commit
d501c92f96
15 files changed
+20
-50
No files matched your search
@@ -67,10 +67,7 @@ ecma_builtin_global_object_print (ecma_value_t this_arg __attr_unused___, /**< t
|
||||
{
|
||||
ecma_value_t ret_value = ecma_make_simple_value (ECMA_SIMPLE_VALUE_EMPTY);
|
||||
|
||||
/*
|
||||
* TODO:
|
||||
* Move the 'print' routine out of engine core.
|
||||
*/
|
||||
/* TODO: Move the 'print' routine out of engine core. */
|
||||
|
||||
for (ecma_length_t arg_index = 0;
|
||||
ecma_is_value_empty (ret_value) && arg_index < args_number;
|
||||
|
||||
@@ -129,9 +129,8 @@ ecma_builtin_regexp_prototype_compile (ecma_value_t this_arg, /**< this argument
|
||||
ecma_property_t *bc_prop_p = ecma_get_internal_property (this_obj_p,
|
||||
ECMA_INTERNAL_PROPERTY_REGEXP_BYTECODE);
|
||||
|
||||
/* FIXME: "We currently have to re-compile the bytecode, because
|
||||
* we can't copy it without knowing its length."
|
||||
*/
|
||||
/* TODO: We currently have to re-compile the bytecode, because
|
||||
* we can't copy it without knowing its length. */
|
||||
const re_compiled_code_t *new_bc_p = NULL;
|
||||
ecma_value_t bc_comp = re_compile_bytecode (&new_bc_p, pattern_string_p, flags);
|
||||
/* Should always succeed, since we're compiling from a source that has been compiled previously. */
|
||||
|
||||
Reference in new issue
Block a user