From b6183baf843e07b4186d023a46ac507ab18837cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Csaba=20Osztrogon=C3=A1c?= Date: Mon, 6 Jul 2020 13:38:50 +0200 Subject: [PATCH] Fix tools/runners/run-test-suite.py with Python 3.6 (#3982) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit text parameter of Popen introduced in Python 3.7, we should use the equivalent universal_newlines. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu --- tools/runners/run-test-suite.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/runners/run-test-suite.py b/tools/runners/run-test-suite.py index 33f8bd345..3c3967c4c 100755 --- a/tools/runners/run-test-suite.py +++ b/tools/runners/run-test-suite.py @@ -83,8 +83,8 @@ def execute_test_command(test_cmd): kwargs = {} if sys.version_info.major >= 3: kwargs['encoding'] = 'unicode_escape' - kwargs['text'] = True - process = subprocess.Popen(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, **kwargs) + process = subprocess.Popen(test_cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, + universal_newlines=True, **kwargs) stdout = process.communicate()[0] return (process.returncode, stdout)