Move cppcheck logic from Makefile and CMakeLists.txt to tools/check-cppcheck.sh

The legacy approach executed cppcheck for every build target, which
resulted in a huge number of re-checks of the sources if more than
one targets were built. The main reason behind that was to get the
right macro-guarded code paths analyzed. However, cppcheck can
analyze every configuration of the sources in one go.

(The patch also contains some aesthetic changes around the way
vera++ is called and how errors are reported.)

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

tools/check-cppcheck.sh

@@ -0,0 +1,35 @@
+#!/bin/bash
+
+# Copyright 2016 Samsung Electronics Co., Ltd.
+# Copyright 2016 University of Szeged
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+CPPCHECK_JOBS=${CPPCHECK_JOBS:=$(nproc)}
+
+JERRY_CORE_DIRS=`find jerry-core -type d`
+JERRY_LIBC_DIRS=`find jerry-libc -type d`
+
+INCLUDE_DIRS=()
+for DIR in $JERRY_CORE_DIRS $JERRY_LIBC_DIRS
+do
+ INCLUDE_DIRS=("${INCLUDE_DIRS[@]}" "-I$DIR")
+done
+
+cppcheck -j$CPPCHECK_JOBS --force \
+ --language=c++ --std=c++11 \
+ --enable=warning,style,performance,portability,information \
+ --error-exitcode=1 \
+ --exitcode-suppressions=tools/cppcheck/suppressions-list \
+ "${INCLUDE_DIRS[@]}" \
+ jerry-core jerry-libc *.c *h tests/unit

tools/check-vera.sh

@@ -19,12 +19,6 @@ JERRY_CORE_FILES=`find ./jerry-core -name "*.c" -or -name "*.cpp" -or -name "*.h
 JERRY_LIBC_FILES=`find ./jerry-libc -name "*.c" -or -name "*.cpp" -or -name "*.h"`
 JERRY_MAIN_FILES=`find . -maxdepth 1 -name "*.c" -or -name "*.cpp" -or -name "*.h"`
 
-vera++ -r tools/vera++ -p jerry $JERRY_CORE_FILES $JERRY_LIBC_FILES $JERRY_MAIN_FILES -e --no-duplicate
-STATUS_CODE=$?
-
-if [ $STATUS_CODE -ne 0 ]
-then
- echo -e "\e[1;33m vera++ static checks failed. See output above for details. \e[0m\n"
-fi
-
-exit $STATUS_CODE
+vera++ -r tools/vera++ -p jerry \
+ -e --no-duplicate \
+ $JERRY_CORE_FILES $JERRY_LIBC_FILES $JERRY_MAIN_FILES 

tools/cppcheck/suppressions-list

@@ -3,4 +3,4 @@ noConstructor
 duplicateExpression
 
 // FIXME: false positive in cppcheck 1.61 (will disappear once distro ships with 1.69)
-variableScope:*/jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c
+variableScope:jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c