YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename 'this' to 'this_arg' in function arguments (#4476)

Browse Source 
'this' is a restricted keyword in C++ so it's a good practice to avoid it's usage as an identifier.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
This commit is contained in:
Robert Fancsik
2021-01-15 18:24:25 +01:00
committed by GitHub
parent 91baa17c51
commit aefd381cf1
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/operations/ecma-promise-object.c
+4 -4
View File
@@ -279,11 +279,11 @@ ecma_fulfill_promise (ecma_value_t promise, /**< promise */
*/ */
ecma_value_t ecma_value_t
ecma_promise_reject_handler (const ecma_value_t function, /**< the function itself */ ecma_promise_reject_handler (const ecma_value_t function, /**< the function itself */
const ecma_value_t this, /**< this_arg of the function */ const ecma_value_t this_arg, /**< this_arg of the function */
const ecma_value_t argv[], /**< argument list */ const ecma_value_t argv[], /**< argument list */
const uint32_t argc) /**< argument number */ const uint32_t argc) /**< argument number */
{ {
JERRY_UNUSED (this); JERRY_UNUSED (this_arg);
ecma_promise_resolver_t *function_p = (ecma_promise_resolver_t *) ecma_get_object_from_value (function); ecma_promise_resolver_t *function_p = (ecma_promise_resolver_t *) ecma_get_object_from_value (function);
/* 1. */ /* 1. */
@@ -313,11 +313,11 @@ ecma_promise_reject_handler (const ecma_value_t function, /**< the function itse
*/ */
ecma_value_t ecma_value_t
ecma_promise_resolve_handler (const ecma_value_t function, /**< the function itself */ ecma_promise_resolve_handler (const ecma_value_t function, /**< the function itself */
const ecma_value_t this, /**< this_arg of the function */ const ecma_value_t this_arg, /**< this_arg of the function */
const ecma_value_t argv[], /**< argument list */ const ecma_value_t argv[], /**< argument list */
const uint32_t argc) /**< argument number */ const uint32_t argc) /**< argument number */
{ {
JERRY_UNUSED (this); JERRY_UNUSED (this_arg);
ecma_promise_resolver_t *function_p = (ecma_promise_resolver_t *) ecma_get_object_from_value (function); ecma_promise_resolver_t *function_p = (ecma_promise_resolver_t *) ecma_get_object_from_value (function);
/* 1. */ /* 1. */
jerry-core/ecma/operations/ecma-promise-object.h
+2 -2
View File
@@ -129,12 +129,12 @@ ecma_value_t ecma_promise_catch_finally_cb (const ecma_value_t function_obj,
const uint32_t args_count); const uint32_t args_count);
ecma_value_t ecma_value_t
ecma_promise_reject_handler (const ecma_value_t function, ecma_promise_reject_handler (const ecma_value_t function,
const ecma_value_t this, const ecma_value_t this_arg,
const ecma_value_t argv[], const ecma_value_t argv[],
const uint32_t argc); const uint32_t argc);
ecma_value_t ecma_value_t
ecma_promise_resolve_handler (const ecma_value_t function, ecma_promise_resolve_handler (const ecma_value_t function,
const ecma_value_t this, const ecma_value_t this_arg,
const ecma_value_t argv[], const ecma_value_t argv[],
const uint32_t argc); const uint32_t argc);