YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use stringbuilder in ecma_builtin_typedarray_prototype_join (#3573)

Browse Source 
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
This commit is contained in:
Szilagyi Adam
2020-02-24 11:15:36 +01:00
committed by GitHub
parent 73daeb19c9
commit acbdb4184f
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
+11 -6
View File
@@ -1134,36 +1134,41 @@ ecma_builtin_typedarray_prototype_join (ecma_value_t this_arg, /**< this argumen
} }
/* 7-8. */ /* 7-8. */
ecma_string_t *return_string_p = ecma_op_typedarray_get_to_string_at_index (obj_p, 0); ecma_string_t *first_string_p = ecma_op_typedarray_get_to_string_at_index (obj_p, 0);
if (JERRY_UNLIKELY (return_string_p == NULL)) if (JERRY_UNLIKELY (first_string_p == NULL))
{ {
ecma_deref_ecma_string (separator_string_p); ecma_deref_ecma_string (separator_string_p);
goto cleanup; goto cleanup;
} }
ecma_stringbuilder_t builder = ecma_stringbuilder_create_from (first_string_p);
ecma_deref_ecma_string (first_string_p);
/* 9-10. */ /* 9-10. */
for (uint32_t k = 1; k < length; k++) for (uint32_t k = 1; k < length; k++)
{ {
/* 10.a */ /* 10.a */
return_string_p = ecma_concat_ecma_strings (return_string_p, separator_string_p); ecma_stringbuilder_append (&builder, separator_string_p);
/* 10.d */ /* 10.d */
ecma_string_t *next_string_p = ecma_op_typedarray_get_to_string_at_index (obj_p, k); ecma_string_t *next_string_p = ecma_op_typedarray_get_to_string_at_index (obj_p, k);
if (JERRY_UNLIKELY (next_string_p == NULL)) if (JERRY_UNLIKELY (next_string_p == NULL))
{ {
ecma_stringbuilder_destroy (&builder);
ecma_deref_ecma_string (separator_string_p); ecma_deref_ecma_string (separator_string_p);
ecma_deref_ecma_string (return_string_p);
goto cleanup; goto cleanup;
} }
return_string_p = ecma_concat_ecma_strings (return_string_p, next_string_p); ecma_stringbuilder_append (&builder, next_string_p);
ecma_deref_ecma_string (next_string_p); ecma_deref_ecma_string (next_string_p);
} }
ecma_deref_ecma_string (separator_string_p); ecma_deref_ecma_string (separator_string_p);
ret_value = ecma_make_string_value (return_string_p); ret_value = ecma_make_string_value (ecma_stringbuilder_finalize (&builder));
} }
cleanup: cleanup: