Rework the public API (#4829)
Related to #4186. Some notable changes: - The term 'Error' now strictly refers to native Error objects defined in the ECMA standard, which are ordinary objects. All other uses of 'error' or 'error reference' where the term refers to a thrown value is now called 'exception'. - Simplified the naming scheme of many String API functions. These functions will now also take an 'encoding' argument to specify the desired encoding in which to operate. - Removed the substring-copy-to-buffer functions. These functions behaved awkwardly, as they use character index to specify the start/end positions, and were mostly used incorrectly with byte offsets instead. The functionality can still be replicated with other functions if necessary. - String-to-buffer functions will no longer fail if the buffer is not sufficiently large, the string will instead be cropped. - Fixed the usage of the '_sz' prefix in many API functions. The term 'sz' means zero-terminated string in hungarian notation, this was used incorrectly in many cases. - Renamed most of the public API functions to have shorter, more on-point names, rather than the often too long descriptive names. Functions are now also grouped by the type of value they operate on, where this makes sense. JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
This commit is contained in:
@@ -26,36 +26,36 @@
|
||||
static jerry_value_t
|
||||
get_canonical_name (const jerry_value_t name)
|
||||
{
|
||||
jerry_size_t name_size = jerry_get_string_size (name);
|
||||
jerry_size_t name_size = jerry_string_size (name, JERRY_ENCODING_CESU8);
|
||||
JERRY_VLA (jerry_char_t, name_string, name_size + 1);
|
||||
jerry_string_to_char_buffer (name, name_string, name_size);
|
||||
jerry_string_to_buffer (name, JERRY_ENCODING_CESU8, name_string, name_size);
|
||||
name_string[name_size] = 0;
|
||||
|
||||
if (!strcmp ((char *) name_string, ACTUAL_NAME))
|
||||
{
|
||||
return jerry_acquire_value (name);
|
||||
return jerry_value_copy (name);
|
||||
}
|
||||
else if (!strcmp ((char *) name_string, ALIAS_NAME))
|
||||
{
|
||||
return jerry_create_string ((jerry_char_t *) ACTUAL_NAME);
|
||||
return jerry_string_sz (ACTUAL_NAME);
|
||||
}
|
||||
else
|
||||
{
|
||||
return jerry_create_undefined ();
|
||||
return jerry_undefined ();
|
||||
}
|
||||
} /* get_canonical_name */
|
||||
|
||||
static bool
|
||||
resolve (const jerry_value_t canonical_name, jerry_value_t *result)
|
||||
{
|
||||
jerry_size_t name_size = jerry_get_string_size (canonical_name);
|
||||
jerry_size_t name_size = jerry_string_size (canonical_name, JERRY_ENCODING_CESU8);
|
||||
JERRY_VLA (jerry_char_t, name_string, name_size + 1);
|
||||
jerry_string_to_char_buffer (canonical_name, name_string, name_size);
|
||||
jerry_string_to_buffer (canonical_name, JERRY_ENCODING_CESU8, name_string, name_size);
|
||||
name_string[name_size] = 0;
|
||||
|
||||
if (!strcmp ((char *) name_string, ACTUAL_NAME))
|
||||
{
|
||||
*result = jerry_create_object ();
|
||||
*result = jerry_object ();
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
@@ -76,28 +76,28 @@ main (int argc, char **argv)
|
||||
|
||||
jerry_init (JERRY_INIT_EMPTY);
|
||||
|
||||
jerry_value_t actual_name = jerry_create_string ((jerry_char_t *) ACTUAL_NAME);
|
||||
jerry_value_t alias_name = jerry_create_string ((jerry_char_t *) ALIAS_NAME);
|
||||
jerry_value_t actual_name = jerry_string_sz (ACTUAL_NAME);
|
||||
jerry_value_t alias_name = jerry_string_sz (ALIAS_NAME);
|
||||
|
||||
/* It's important that we resolve by the non-canonical name first. */
|
||||
jerry_value_t result2 = jerryx_module_resolve (alias_name, &resolver, 1);
|
||||
jerry_value_t result1 = jerryx_module_resolve (actual_name, &resolver, 1);
|
||||
jerry_release_value (actual_name);
|
||||
jerry_release_value (alias_name);
|
||||
jerry_value_free (actual_name);
|
||||
jerry_value_free (alias_name);
|
||||
|
||||
/* An elaborate way of doing strict equal - set a property on one object and it "magically" appears on the other. */
|
||||
jerry_value_t prop_name = jerry_create_string ((jerry_char_t *) "something");
|
||||
jerry_value_t prop_value = jerry_create_number (TEST_VALUE);
|
||||
jerry_release_value (jerry_set_property (result1, prop_name, prop_value));
|
||||
jerry_release_value (prop_value);
|
||||
jerry_value_t prop_name = jerry_string_sz ("something");
|
||||
jerry_value_t prop_value = jerry_number (TEST_VALUE);
|
||||
jerry_value_free (jerry_object_set (result1, prop_name, prop_value));
|
||||
jerry_value_free (prop_value);
|
||||
|
||||
prop_value = jerry_get_property (result2, prop_name);
|
||||
TEST_ASSERT (jerry_get_number_value (prop_value) == TEST_VALUE);
|
||||
jerry_release_value (prop_value);
|
||||
prop_value = jerry_object_get (result2, prop_name);
|
||||
TEST_ASSERT (jerry_value_as_number (prop_value) == TEST_VALUE);
|
||||
jerry_value_free (prop_value);
|
||||
|
||||
jerry_release_value (prop_name);
|
||||
jerry_release_value (result1);
|
||||
jerry_release_value (result2);
|
||||
jerry_value_free (prop_name);
|
||||
jerry_value_free (result1);
|
||||
jerry_value_free (result2);
|
||||
|
||||
jerry_cleanup ();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user