YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rework the public API (#4829)

Browse Source 
Related to #4186.

Some notable changes:
  - The term 'Error' now strictly refers to native Error objects defined in
    the ECMA standard, which are ordinary objects. All other uses of
    'error' or 'error reference' where the term refers to a thrown value is
    now called 'exception'.

  - Simplified the naming scheme of many String API functions. These functions
    will now also take an 'encoding' argument to specify the desired
    encoding in which to operate.

  - Removed the substring-copy-to-buffer functions. These functions
    behaved awkwardly, as they use character index to specify the
    start/end positions, and were mostly used incorrectly with byte
    offsets instead. The functionality can still be replicated with
    other functions if necessary.

  - String-to-buffer functions will no longer fail if the buffer is not
    sufficiently large, the string will instead be cropped.

  - Fixed the usage of the '_sz' prefix in many API functions. The term
    'sz' means zero-terminated string in hungarian notation, this was
    used incorrectly in many cases.

  - Renamed most of the public API functions to have shorter, more on-point
    names, rather than the often too long descriptive names. Functions are now
    also grouped by the type of value they operate on, where this makes
    sense.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
This commit is contained in:
Dániel Bátyai
2021-12-06 10:20:09 +01:00
committed by GitHub
parent 81d2319144
commit 9860d66a56
180 changed files with 10738 additions and 11025 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit-core/test-dataview.c
+38 -38
View File
@@ -22,82 +22,82 @@
int
main (void)
{
if (!jerry_is_feature_enabled (JERRY_FEATURE_DATAVIEW))
if (!jerry_feature_enabled (JERRY_FEATURE_DATAVIEW))
{
jerry_port_log (JERRY_LOG_LEVEL_ERROR, "DataView support is disabled!\n");
return 0;
}
/* DataView builtin requires the TypedArray builtin */
TEST_ASSERT (jerry_is_feature_enabled (JERRY_FEATURE_TYPEDARRAY));
TEST_ASSERT (jerry_feature_enabled (JERRY_FEATURE_TYPEDARRAY));
jerry_init (JERRY_INIT_EMPTY);
/* Test accessors */
jerry_value_t arraybuffer = jerry_create_arraybuffer (16);
jerry_value_t view1 = jerry_create_dataview (arraybuffer, 0, 16);
TEST_ASSERT (!jerry_value_is_error (view1));
jerry_value_t arraybuffer = jerry_arraybuffer (16);
jerry_value_t view1 = jerry_dataview (arraybuffer, 0, 16);
TEST_ASSERT (!jerry_value_is_exception (view1));
TEST_ASSERT (jerry_value_is_dataview (view1));
jerry_length_t byteOffset = 0;
jerry_length_t byteLength = 0;
;
jerry_value_t internal_buffer = jerry_get_dataview_buffer (view1, &byteOffset, &byteLength);
TEST_ASSERT (jerry_binary_operation (JERRY_BIN_OP_STRICT_EQUAL, internal_buffer, arraybuffer));
jerry_value_t internal_buffer = jerry_dataview_buffer (view1, &byteOffset, &byteLength);
TEST_ASSERT (jerry_binary_op (JERRY_BIN_OP_STRICT_EQUAL, internal_buffer, arraybuffer));
TEST_ASSERT (byteOffset == 0);
TEST_ASSERT (byteLength == 16);
jerry_release_value (internal_buffer);
jerry_value_free (internal_buffer);
jerry_value_t view2 = jerry_create_dataview (arraybuffer, 12, 4);
TEST_ASSERT (!jerry_value_is_error (view1));
jerry_value_t view2 = jerry_dataview (arraybuffer, 12, 4);
TEST_ASSERT (!jerry_value_is_exception (view1));
TEST_ASSERT (jerry_value_is_dataview (view2));
internal_buffer = jerry_get_dataview_buffer (view2, &byteOffset, &byteLength);
TEST_ASSERT (jerry_binary_operation (JERRY_BIN_OP_STRICT_EQUAL, internal_buffer, arraybuffer));
internal_buffer = jerry_dataview_buffer (view2, &byteOffset, &byteLength);
TEST_ASSERT (jerry_binary_op (JERRY_BIN_OP_STRICT_EQUAL, internal_buffer, arraybuffer));
TEST_ASSERT (byteOffset == 12);
TEST_ASSERT (byteLength == 4);
jerry_release_value (internal_buffer);
jerry_value_free (internal_buffer);
/* Test invalid construction */
jerry_value_t empty_object = jerry_create_object ();
jerry_value_t view3 = jerry_create_dataview (empty_object, 20, 10);
TEST_ASSERT (jerry_value_is_error (view3));
jerry_value_t error_obj = jerry_get_value_from_error (view3, true);
TEST_ASSERT (jerry_get_error_type (error_obj) == JERRY_ERROR_TYPE);
jerry_release_value (error_obj);
jerry_release_value (empty_object);
jerry_value_t empty_object = jerry_object ();
jerry_value_t view3 = jerry_dataview (empty_object, 20, 10);
TEST_ASSERT (jerry_value_is_exception (view3));
jerry_value_t error_obj = jerry_exception_value (view3, true);
TEST_ASSERT (jerry_error_type (error_obj) == JERRY_ERROR_TYPE);
jerry_value_free (error_obj);
jerry_value_free (empty_object);
jerry_value_t view4 = jerry_create_dataview (arraybuffer, 20, 10);
TEST_ASSERT (jerry_value_is_error (view3));
error_obj = jerry_get_value_from_error (view4, true);
TEST_ASSERT (jerry_get_error_type (error_obj) == JERRY_ERROR_RANGE);
jerry_release_value (error_obj);
jerry_value_t view4 = jerry_dataview (arraybuffer, 20, 10);
TEST_ASSERT (jerry_value_is_exception (view3));
error_obj = jerry_exception_value (view4, true);
TEST_ASSERT (jerry_error_type (error_obj) == JERRY_ERROR_RANGE);
jerry_value_free (error_obj);
/* Test getting/setting values */
jerry_value_t global_obj = jerry_get_global_object ();
jerry_value_t view1_str = jerry_create_string ((const jerry_char_t *) "view1");
jerry_value_t view2_str = jerry_create_string ((const jerry_char_t *) "view2");
TEST_ASSERT (jerry_set_property (global_obj, view1_str, view1));
TEST_ASSERT (jerry_set_property (global_obj, view2_str, view2));
jerry_value_t global_obj = jerry_current_realm ();
jerry_value_t view1_str = jerry_string_sz ("view1");
jerry_value_t view2_str = jerry_string_sz ("view2");
TEST_ASSERT (jerry_object_set (global_obj, view1_str, view1));
TEST_ASSERT (jerry_object_set (global_obj, view2_str, view2));
jerry_release_value (view1_str);
jerry_release_value (view2_str);
jerry_release_value (global_obj);
jerry_value_free (view1_str);
jerry_value_free (view2_str);
jerry_value_free (global_obj);
const jerry_char_t set_src[] = "view1.setInt16 (12, 255)";
TEST_ASSERT (jerry_value_is_undefined (jerry_eval (set_src, sizeof (set_src) - 1, JERRY_PARSE_NO_OPTS)));
const jerry_char_t get_src[] = "view2.getInt16 (0)";
TEST_ASSERT (jerry_get_number_value (jerry_eval (get_src, sizeof (get_src) - 1, JERRY_PARSE_NO_OPTS)) == 255);
TEST_ASSERT (jerry_value_as_number (jerry_eval (get_src, sizeof (get_src) - 1, JERRY_PARSE_NO_OPTS)) == 255);
const jerry_char_t get_src_little_endian[] = "view2.getInt16 (0, true)";
TEST_ASSERT (
jerry_get_number_value (jerry_eval (get_src_little_endian, sizeof (get_src_little_endian) - 1, JERRY_PARSE_NO_OPTS))
jerry_value_as_number (jerry_eval (get_src_little_endian, sizeof (get_src_little_endian) - 1, JERRY_PARSE_NO_OPTS))
== -256);
/* Cleanup */
jerry_release_value (view2);
jerry_release_value (view1);
jerry_release_value (arraybuffer);
jerry_value_free (view2);
jerry_value_free (view1);
jerry_value_free (arraybuffer);
jerry_cleanup ();