YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rework the public API (#4829)

Browse Source 
Related to #4186.

Some notable changes:
  - The term 'Error' now strictly refers to native Error objects defined in
    the ECMA standard, which are ordinary objects. All other uses of
    'error' or 'error reference' where the term refers to a thrown value is
    now called 'exception'.

  - Simplified the naming scheme of many String API functions. These functions
    will now also take an 'encoding' argument to specify the desired
    encoding in which to operate.

  - Removed the substring-copy-to-buffer functions. These functions
    behaved awkwardly, as they use character index to specify the
    start/end positions, and were mostly used incorrectly with byte
    offsets instead. The functionality can still be replicated with
    other functions if necessary.

  - String-to-buffer functions will no longer fail if the buffer is not
    sufficiently large, the string will instead be cropped.

  - Fixed the usage of the '_sz' prefix in many API functions. The term
    'sz' means zero-terminated string in hungarian notation, this was
    used incorrectly in many cases.

  - Renamed most of the public API functions to have shorter, more on-point
    names, rather than the often too long descriptive names. Functions are now
    also grouped by the type of value they operate on, where this makes
    sense.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu
This commit is contained in:
Dániel Bátyai
2021-12-06 10:20:09 +01:00
committed by GitHub
parent 81d2319144
commit 9860d66a56
180 changed files with 10738 additions and 11025 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit-core/test-api-property.c
+51 -51
View File
@@ -25,47 +25,47 @@ main (void)
jerry_init (JERRY_INIT_EMPTY);
/* Test: init property descriptor */
jerry_property_descriptor_t prop_desc = jerry_property_descriptor_create ();
jerry_property_descriptor_t prop_desc = jerry_property_descriptor ();
TEST_ASSERT (prop_desc.flags == JERRY_PROP_NO_OPTS);
TEST_ASSERT (jerry_value_is_undefined (prop_desc.value));
TEST_ASSERT (jerry_value_is_undefined (prop_desc.getter));
TEST_ASSERT (jerry_value_is_undefined (prop_desc.setter));
/* Test: define own properties */
jerry_value_t global_obj_val = jerry_get_global_object ();
jerry_value_t prop_name = jerry_create_string ((const jerry_char_t *) "my_defined_property");
jerry_value_t global_obj_val = jerry_current_realm ();
jerry_value_t prop_name = jerry_string_sz ("my_defined_property");
prop_desc.flags |= JERRY_PROP_IS_VALUE_DEFINED;
prop_desc.value = jerry_acquire_value (prop_name);
jerry_value_t res = jerry_define_own_property (global_obj_val, prop_name, &prop_desc);
prop_desc.value = jerry_value_copy (prop_name);
jerry_value_t res = jerry_object_define_own_prop (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_boolean (res) && jerry_value_is_true (res));
jerry_release_value (res);
jerry_value_free (res);
jerry_property_descriptor_free (&prop_desc);
/* Test: define own property with error */
prop_desc = jerry_property_descriptor_create ();
prop_desc = jerry_property_descriptor ();
prop_desc.flags |= JERRY_PROP_IS_VALUE_DEFINED | JERRY_PROP_SHOULD_THROW;
prop_desc.value = jerry_create_number (3.14);
res = jerry_define_own_property (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_error (res));
jerry_release_value (res);
prop_desc.value = jerry_number (3.14);
res = jerry_object_define_own_prop (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_exception (res));
jerry_value_free (res);
jerry_property_descriptor_free (&prop_desc);
/* Test: test define own property failure without throw twice */
prop_desc = jerry_property_descriptor_create ();
prop_desc = jerry_property_descriptor ();
prop_desc.flags |= JERRY_PROP_IS_VALUE_DEFINED | JERRY_PROP_IS_GET_DEFINED;
res = jerry_define_own_property (prop_name, prop_name, &prop_desc);
res = jerry_object_define_own_prop (prop_name, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_boolean (res) && !jerry_value_is_true (res));
jerry_release_value (res);
res = jerry_define_own_property (global_obj_val, prop_name, &prop_desc);
jerry_value_free (res);
res = jerry_object_define_own_prop (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_boolean (res) && !jerry_value_is_true (res));
jerry_release_value (res);
jerry_value_free (res);
jerry_property_descriptor_free (&prop_desc);
/* Test: get own property descriptor */
prop_desc = jerry_property_descriptor_create ();
jerry_value_t is_ok = jerry_get_own_property_descriptor (global_obj_val, prop_name, &prop_desc);
prop_desc = jerry_property_descriptor ();
jerry_value_t is_ok = jerry_object_get_own_prop (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_boolean (is_ok) && jerry_value_is_true (is_ok));
jerry_release_value (is_ok);
jerry_value_free (is_ok);
TEST_ASSERT (prop_desc.flags & JERRY_PROP_IS_VALUE_DEFINED);
TEST_ASSERT (jerry_value_is_string (prop_desc.value));
TEST_ASSERT (!(prop_desc.flags & JERRY_PROP_IS_WRITABLE));
@@ -77,61 +77,61 @@ main (void)
TEST_ASSERT (jerry_value_is_undefined (prop_desc.setter));
jerry_property_descriptor_free (&prop_desc);
if (jerry_is_feature_enabled (JERRY_FEATURE_PROXY))
if (jerry_feature_enabled (JERRY_FEATURE_PROXY))
{
/* Note: update this test when the internal method is implemented */
jerry_value_t target = jerry_create_object ();
jerry_value_t handler = jerry_create_object ();
jerry_value_t proxy = jerry_create_proxy (target, handler);
jerry_value_t target = jerry_object ();
jerry_value_t handler = jerry_object ();
jerry_value_t proxy = jerry_proxy (target, handler);
jerry_release_value (target);
jerry_release_value (handler);
is_ok = jerry_get_own_property_descriptor (proxy, prop_name, &prop_desc);
jerry_value_free (target);
jerry_value_free (handler);
is_ok = jerry_object_get_own_prop (proxy, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_boolean (is_ok) && !jerry_value_is_true (is_ok));
jerry_release_value (is_ok);
jerry_release_value (proxy);
jerry_value_free (is_ok);
jerry_value_free (proxy);
}
jerry_release_value (prop_name);
jerry_value_free (prop_name);
/* Test: define and get own property descriptor */
prop_desc.flags |= JERRY_PROP_IS_ENUMERABLE;
prop_name = jerry_create_string ((const jerry_char_t *) "enumerable-property");
res = jerry_define_own_property (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (!jerry_value_is_error (res));
prop_name = jerry_string_sz ("enumerable-property");
res = jerry_object_define_own_prop (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (!jerry_value_is_exception (res));
TEST_ASSERT (jerry_value_is_boolean (res));
TEST_ASSERT (jerry_value_is_true (res));
jerry_release_value (res);
jerry_value_free (res);
jerry_property_descriptor_free (&prop_desc);
is_ok = jerry_get_own_property_descriptor (global_obj_val, prop_name, &prop_desc);
is_ok = jerry_object_get_own_prop (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_boolean (is_ok) && jerry_value_is_true (is_ok));
jerry_release_value (is_ok);
jerry_value_free (is_ok);
TEST_ASSERT (!(prop_desc.flags & JERRY_PROP_IS_WRITABLE));
TEST_ASSERT (prop_desc.flags & JERRY_PROP_IS_ENUMERABLE);
TEST_ASSERT (!(prop_desc.flags & JERRY_PROP_IS_CONFIGURABLE));
jerry_release_value (prop_name);
jerry_release_value (global_obj_val);
jerry_value_free (prop_name);
jerry_value_free (global_obj_val);
/* Test: define own property descriptor error */
prop_desc = jerry_property_descriptor_create ();
prop_desc = jerry_property_descriptor ();
prop_desc.flags |= JERRY_PROP_IS_VALUE_DEFINED;
prop_desc.value = jerry_create_number (11);
prop_desc.value = jerry_number (11);
jerry_value_t obj_val = jerry_create_object ();
prop_name = jerry_create_string ((const jerry_char_t *) "property_key");
res = jerry_define_own_property (obj_val, prop_name, &prop_desc);
TEST_ASSERT (!jerry_value_is_error (res));
jerry_release_value (res);
jerry_value_t obj_val = jerry_object ();
prop_name = jerry_string_sz ("property_key");
res = jerry_object_define_own_prop (obj_val, prop_name, &prop_desc);
TEST_ASSERT (!jerry_value_is_exception (res));
jerry_value_free (res);
jerry_release_value (prop_desc.value);
prop_desc.value = jerry_create_number (22);
res = jerry_define_own_property (obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_error (res));
jerry_release_value (res);
jerry_value_free (prop_desc.value);
prop_desc.value = jerry_number (22);
res = jerry_object_define_own_prop (obj_val, prop_name, &prop_desc);
TEST_ASSERT (jerry_value_is_exception (res));
jerry_value_free (res);
jerry_release_value (prop_name);
jerry_release_value (obj_val);
jerry_value_free (prop_name);
jerry_value_free (obj_val);
jerry_cleanup ();