YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak in the snapshot creation. (#2533)

Browse Source 
Bytecode must be freed when the source is parsed succesfully,
but the snapshot generating fails for some other reason.

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
This commit is contained in:
László Langó
2018-09-19 20:47:16 +02:00
committed by Robert Sipka
parent cfa7cfc08c
commit 81810d58f8
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/api/jerry-snapshot.c
+4
View File
@@ -768,6 +768,8 @@ jerry_generate_snapshot_with_args (const jerry_char_t *resource_name_p, /**< scr
return ecma_create_error_reference (JERRY_CONTEXT (error_value), true); return ecma_create_error_reference (JERRY_CONTEXT (error_value), true);
} }
JERRY_ASSERT (bytecode_data_p != NULL);
if (generate_snapshot_opts & JERRY_SNAPSHOT_SAVE_STATIC) if (generate_snapshot_opts & JERRY_SNAPSHOT_SAVE_STATIC)
{ {
static_snapshot_add_compiled_code (bytecode_data_p, (uint8_t *) buffer_p, buffer_size, &globals); static_snapshot_add_compiled_code (bytecode_data_p, (uint8_t *) buffer_p, buffer_size, &globals);
@@ -779,6 +781,7 @@ jerry_generate_snapshot_with_args (const jerry_char_t *resource_name_p, /**< scr
if (!ecma_is_value_empty (globals.snapshot_error)) if (!ecma_is_value_empty (globals.snapshot_error))
{ {
ecma_bytecode_deref (bytecode_data_p);
return globals.snapshot_error; return globals.snapshot_error;
} }
@@ -808,6 +811,7 @@ jerry_generate_snapshot_with_args (const jerry_char_t *resource_name_p, /**< scr
{ {
JERRY_ASSERT (lit_map_p == NULL); JERRY_ASSERT (lit_map_p == NULL);
const char * const error_message_p = "Cannot allocate memory for literals."; const char * const error_message_p = "Cannot allocate memory for literals.";
ecma_bytecode_deref (bytecode_data_p);
return jerry_create_error (JERRY_ERROR_COMMON, (const jerry_char_t *) error_message_p); return jerry_create_error (JERRY_ERROR_COMMON, (const jerry_char_t *) error_message_p);
} }