Implement operations of atomics (#5166)

The following methods were implemented:
 - Atomics.compareExchange
 - Atomics.store

The implementation is based on PR #4956, only resolved the conflicts.

Co-authored-by: Csaba Repasi repasics@inf.u-szeged.hu
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu

tests/jerry/atomics.js

@@ -13,19 +13,9 @@
 // limitations under the License.
 
 const buffer = new SharedArrayBuffer (16);
-const uint8 = new Uint8Array (buffer);
-uint8[0] = 7;
+const uint8 = new Uint8Array(buffer);
 
-Atomics.add (uint8, 0, 2);
-Atomics.and (uint8, 0, 2);
-Atomics.compareExchange (uint8, 0, 5, 2);
-Atomics.exchange (uint8, 0, 2);
-Atomics.or (uint8, 0, 2);
-Atomics.sub (uint8, 0, 2);
-Atomics.xor (uint8, 0, 2)
-Atomics.isLockFree (3);
-Atomics.load (uint8, 0);
-Atomics.store (uint8, 0, 2);
+Atomics.isLockFree(3);
 
 const sab = new SharedArrayBuffer (1024);
 const int32 = new Int32Array (sab);
@@ -36,30 +26,261 @@ Atomics.notify (int32, 0, 1);
 try {
   let a;
   Atomics.add (a, 0, 0);
+  assert(false);
 } catch (ex) {
   assert (ex instanceof TypeError);
 }
 
 try {
   Atomics.add (new Float32Array(10), 0, 2);
-} catch (ex) {
-  assert (ex instanceof TypeError);
-}
-try{
-  const uint16 = new Uint16Array (new ArrayBuffer (16));
-  Atomics.add(uint16, 0, 0);
+  assert(false);
 } catch (ex) {
   assert (ex instanceof TypeError);
 }
 
 try {
   Atomics.add (uint8, 100, 0);
+  assert(false);
 } catch (ex) {
   assert (ex instanceof RangeError);
 }
 
 try {
   Atomics.add (uint8, -1, 0);
+  assert(false);
 } catch (ex) {
   assert (ex instanceof RangeError);
 }
+
+assert(Atomics.store(uint8, 0, -1) === -1);
+assert(Atomics.add(uint8, 0, 1) === 255);
+assert(Atomics.load(uint8, 0) === 0);
+
+const ta_int8 = new Int8Array(new ArrayBuffer(2));
+ta_int8[0] = 5;
+
+Atomics.store(ta_int8, 1, 127)
+
+assert(Atomics.load(ta_int8, 0) === 5);
+
+assert(Atomics.add(ta_int8, 0, 12) === 5);
+assert(Atomics.load(ta_int8, 0) === 17);
+
+assert(Atomics.and(ta_int8, 0, 1) === 17);
+assert(Atomics.load(ta_int8, 0) === 1);
+
+assert(Atomics.compareExchange(ta_int8, 0, 5, 123) === 1);
+assert(Atomics.load(ta_int8, 0) === 1);
+
+assert(Atomics.compareExchange(ta_int8, 1, 123, ta_int8[0]) === 127);
+assert(Atomics.load(ta_int8, 0) === 1);
+
+assert(Atomics.compareExchange(ta_int8, 0, 1, 123) === 1);
+assert(Atomics.load(ta_int8, 0) === 123);
+
+assert(Atomics.store(ta_int8, 0, -0) === 0);
+assert(Atomics.load(ta_int8, 0) === 0);
+
+assert(Atomics.store(ta_int8, 0, 1) === 1);
+assert(Atomics.load(ta_int8, 0) === 1);
+
+assert(Atomics.exchange(ta_int8, 0, 12) === 1);
+assert(Atomics.load(ta_int8, 0) === 12);
+
+assert(Atomics.or(ta_int8, 0, 1) === 12);
+assert(Atomics.load(ta_int8, 0) === 13);
+
+assert(Atomics.sub(ta_int8, 0, 2) === 13);
+assert(Atomics.load(ta_int8, 0) === 11);
+
+assert(Atomics.xor(ta_int8, 0, 1) === 11);
+assert(Atomics.load(ta_int8, 0) === 10);
+
+const ta_bigintint64 = new BigInt64Array(new ArrayBuffer(16));
+ta_bigintint64[0] = 5n;
+
+Atomics.store(ta_bigintint64, 1, 127n)
+
+assert(Atomics.load(ta_bigintint64, 0) === 5n);
+
+assert(Atomics.add(ta_bigintint64, 0, 12n) === 5n);
+assert(Atomics.load(ta_bigintint64, 0) === 17n);
+
+assert(Atomics.and(ta_bigintint64, 0, 1n) === 17n);
+assert(Atomics.load(ta_bigintint64, 0) === 1n);
+
+assert(Atomics.compareExchange(ta_bigintint64, 0, 5n, 123n) === 1n);
+assert(Atomics.load(ta_bigintint64, 0) === 1n);
+
+assert(Atomics.compareExchange(ta_bigintint64, 1, 123n, ta_bigintint64[0]) === 127n);
+assert(Atomics.load(ta_bigintint64, 0) === 1n);
+
+assert(Atomics.compareExchange(ta_bigintint64, 0, 1n, 123n) === 1n);
+assert(Atomics.load(ta_bigintint64, 0) === 123n);
+
+assert(Atomics.store(ta_bigintint64, 0, -0n) === 0n);
+assert(Atomics.load(ta_bigintint64, 0) === 0n);
+
+assert(Atomics.store(ta_bigintint64, 0, 1n) === 1n);
+assert(Atomics.load(ta_bigintint64, 0) === 1n);
+
+assert(Atomics.exchange(ta_bigintint64, 0, 12n) === 1n);
+assert(Atomics.load(ta_bigintint64, 0) === 12n);
+
+assert(Atomics.or(ta_bigintint64, 0, 1n) === 12n);
+assert(Atomics.load(ta_bigintint64, 0) === 13n);
+
+assert(Atomics.sub(ta_bigintint64, 0, 2n) === 13n);
+assert(Atomics.load(ta_bigintint64, 0) === 11n);
+
+assert(Atomics.xor(ta_bigintint64, 0, 1n) === 11n);
+assert(Atomics.load(ta_bigintint64, 0) === 10n);
+
+try {
+  Atomics.store(ta_bigintint64, 0, 1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.store(ta_int8, 0, 1n);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.store(ta_int8, 0n, 1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.store(ta_int8, 2, 1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof RangeError);
+}
+
+try {
+  Atomics.store(ta_int8, -1, 1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof RangeError);
+}
+
+try {
+  Atomics.load(ta_int8, 0n);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.load(ta_int8, 2);
+  assert(false);
+} catch (e) {
+  assert(e instanceof RangeError);
+}
+
+try {
+  Atomics.load(ta_int8, -1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof RangeError);
+}
+
+try {
+  Atomics.exchange(ta_bigintint64, 0, 1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.exchange(ta_int8, 0, 1n);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.exchange(ta_int8, 0n, 1);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_bigintint64, 0n, 1n, 0n);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_bigintint64, 0, 1, 0n);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_int8, 0, 1n, 0);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_bigintint64, 0, 1n, 0);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_int8, 0, 1, 0n);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_int8, 2, 1, 0);
+  assert(false);
+} catch (e) {
+  assert(e instanceof RangeError);
+}
+
+try {
+  Atomics.compareExchange(ta_int8, -1, 1, 0);
+  assert(false);
+} catch (e) {
+  assert(e instanceof RangeError);
+}
+
+const ta_float32 = new Float32Array(new ArrayBuffer(4));
+
+try {
+  Atomics.store(ta_float32, 0, 127);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.load(ta_float32, 0);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}
+
+try {
+  Atomics.compareExchange(ta_float32, 0, 1, 0);
+  assert(false);
+} catch (e) {
+  assert(e instanceof TypeError);
+}

tests/snapshot-tests-skiplist.txt

@@ -1,3 +1,4 @@
+tests/jerry/atomics.js
 tests/jerry/bigint-typedarray-prototype-filter.js
 tests/jerry/bigint5.js
 tests/jerry/bigint6.js

tests/test262-excludelist.xml

@@ -2486,39 +2486,7 @@
        features: [Atomics]
        https://github.com/tc39/ecmascript_sharedmem
   -->
-  <test id="built-ins/Atomics/add/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/add/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/add/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/add/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/add/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bigint/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/non-shared-int-views-throws.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/non-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/validate-arraytype-before-expectedValue-coercion.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/validate-arraytype-before-index-coercion.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/validate-arraytype-before-replacementValue-coercion.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/non-shared-bufferdata.js"><reason></reason></test>
   <test id="built-ins/Atomics/isLockFree/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/non-shared-bufferdata.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/bigint/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/bigint/non-bigint64-typedarray-throws.js"><reason></reason></test>
@@ -2558,27 +2526,6 @@
   <test id="built-ins/Atomics/notify/undefined-index-defaults-to-zero.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/validate-arraytype-before-count-coercion.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/validate-arraytype-before-index-coercion.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bigint/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/non-shared-int-views-throws.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/non-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/validate-arraytype-before-index-coercion.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/validate-arraytype-before-value-coercion.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/non-shared-bufferdata.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/bigint/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/bigint/cannot-suspend-throws.js"><reason></reason></test>
@@ -2652,34 +2599,11 @@
   <test id="built-ins/Atomics/wait/waiterlist-block-indexedposition-wake.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/waiterlist-order-of-operations-is-fifo.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/was-woken-before-timeout.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/bigint/non-shared-bufferdata.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/non-shared-bufferdata.js"><reason></reason></test>
 
   <!-- ES2017: Shared Memory and Atomics
        features: [SharedArrayBuffer]
        https://github.com/tc39/ecmascript_sharedmem
   -->
-  <test id="built-ins/Atomics/add/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/add/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/add/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/and/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bigint/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/compareExchange/non-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/exchange/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/load/good-views.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/bigint/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/bigint/notify-all-on-loc.js"><reason></reason></test>
@@ -2705,18 +2629,6 @@
   <test id="built-ins/Atomics/notify/out-of-range-index-throws.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/symbol-for-index-throws.js"><reason></reason></test>
   <test id="built-ins/Atomics/notify/undefined-index-defaults-to-zero.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/or/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bigint/bad-range.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/store/non-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/sub/good-views.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/bigint/bad-range.js"><reason></reason></test>
   <test id="built-ins/Atomics/wait/bigint/cannot-suspend-throws.js"><reason></reason></test>
@@ -2865,9 +2777,6 @@
   <test id="built-ins/Atomics/waitAsync/value-not-equal.js"><reason></reason></test>
   <test id="built-ins/Atomics/waitAsync/waiterlist-block-indexedposition-wake.js"><reason></reason></test>
   <test id="built-ins/Atomics/waitAsync/was-woken-before-timeout.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/bigint/good-views.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/expected-return-value.js"><reason></reason></test>
-  <test id="built-ins/Atomics/xor/good-views.js"><reason></reason></test>
   <test id="built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/typedarray-backed-by-sharedarraybuffer.js"><reason></reason></test>
   <test id="built-ins/TypedArrayConstructors/ctors/buffer-arg/typedarray-backed-by-sharedarraybuffer.js"><reason></reason></test>
   <!-- END - ES2017: Shared Memory and Atomics -->