YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix buffer size in Number.prototype.toFixed()

Browse Source 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
This commit is contained in:
Dániel Bátyai
2015-06-22 15:22:49 +02:00
parent 216dc251ec
commit 7d3bb85ccb
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.cpp
+8 -1
View File
@@ -268,7 +268,13 @@ ecma_builtin_number_prototype_object_to_fixed (ecma_value_t this_arg, /**< this
else else
{ {
/* Buffer that is used to construct the string. */ /* Buffer that is used to construct the string. */
int buffer_size = (exponent > 0) ? exponent + frac_digits + 1 : frac_digits + 2; int buffer_size = (exponent > 0) ? exponent + frac_digits + 2 : frac_digits + 3;
if (is_negative)
{
buffer_size++;
}
JERRY_ASSERT (buffer_size > 0); JERRY_ASSERT (buffer_size > 0);
MEM_DEFINE_LOCAL_ARRAY (buff, buffer_size, ecma_char_t); MEM_DEFINE_LOCAL_ARRAY (buff, buffer_size, ecma_char_t);
@@ -360,6 +366,7 @@ ecma_builtin_number_prototype_object_to_fixed (ecma_value_t this_arg, /**< this
} }
} }
JERRY_ASSERT (p - buff < buffer_size);
/* String terminator. */ /* String terminator. */
*p = 0; *p = 0;
ecma_string_t* str = ecma_new_ecma_string ((ecma_char_t *) buff); ecma_string_t* str = ecma_new_ecma_string ((ecma_char_t *) buff);