YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing assertion checks with possible side effects.

Browse Source
This commit is contained in:
Ruben Ayrapetyan
2014-11-27 21:04:14 +03:00
parent f6e7621d3f
commit 7b75dcf0c9
2 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libecmaobjects/ecma-helpers.c
+4
View File
@@ -411,6 +411,8 @@ ecma_property_t*
ecma_create_internal_property (ecma_object_t *object_p, /**< the object */ ecma_create_internal_property (ecma_object_t *object_p, /**< the object */
ecma_internal_property_id_t property_id) /**< internal property identifier */ ecma_internal_property_id_t property_id) /**< internal property identifier */
{ {
JERRY_ASSERT (ecma_find_internal_property (object_p, property_id) == NULL);
ecma_property_t *new_property_p = ecma_alloc_property (); ecma_property_t *new_property_p = ecma_alloc_property ();
new_property_p->type = ECMA_PROPERTY_INTERNAL; new_property_p->type = ECMA_PROPERTY_INTERNAL;
@@ -489,6 +491,7 @@ ecma_create_named_data_property (ecma_object_t *obj_p, /**< object */
ecma_property_configurable_value_t configurable) /**< 'configurable' attribute */ ecma_property_configurable_value_t configurable) /**< 'configurable' attribute */
{ {
JERRY_ASSERT(obj_p != NULL && name_p != NULL); JERRY_ASSERT(obj_p != NULL && name_p != NULL);
JERRY_ASSERT(ecma_find_named_property (obj_p, name_p) == NULL);
ecma_property_t *prop_p = ecma_alloc_property (); ecma_property_t *prop_p = ecma_alloc_property ();
@@ -528,6 +531,7 @@ ecma_create_named_accessor_property (ecma_object_t *obj_p, /**< object */
ecma_property_configurable_value_t configurable) /**< 'configurable' attribute */ ecma_property_configurable_value_t configurable) /**< 'configurable' attribute */
{ {
JERRY_ASSERT(obj_p != NULL && name_p != NULL); JERRY_ASSERT(obj_p != NULL && name_p != NULL);
JERRY_ASSERT(ecma_find_named_property (obj_p, name_p) == NULL);
ecma_property_t *prop_p = ecma_alloc_property (); ecma_property_t *prop_p = ecma_alloc_property ();
src/libecmaoperations/ecma-lex-env.c
+1 -11
View File
@@ -68,7 +68,7 @@ ecma_op_has_binding (ecma_object_t *lex_env_p, /**< lexical environment */
/** /**
* CreateMutableBinding operation. * CreateMutableBinding operation.
* *
* see also: ecma-262 v5, 10.2.1 * See also: ECMA-262 v5, 10.2.1
* *
* @return completion value * @return completion value
* Returned value must be freed with ecma_free_completion_value * Returned value must be freed with ecma_free_completion_value
@@ -86,8 +86,6 @@ ecma_op_create_mutable_binding (ecma_object_t *lex_env_p, /**< lexical environme
{ {
case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE: case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE:
{ {
JERRY_ASSERT(!ecma_op_has_binding (lex_env_p, name_p));
ecma_create_named_data_property (lex_env_p, ecma_create_named_data_property (lex_env_p,
name_p, name_p,
ECMA_PROPERTY_WRITABLE, ECMA_PROPERTY_WRITABLE,
@@ -155,8 +153,6 @@ ecma_op_set_mutable_binding (ecma_object_t *lex_env_p, /**< lexical environment
&& ecma_is_lexical_environment (lex_env_p)); && ecma_is_lexical_environment (lex_env_p));
JERRY_ASSERT(name_p != NULL); JERRY_ASSERT(name_p != NULL);
JERRY_ASSERT(ecma_op_has_binding (lex_env_p, name_p));
switch (ecma_get_lex_env_type (lex_env_p)) switch (ecma_get_lex_env_type (lex_env_p))
{ {
case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE: case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE:
@@ -236,8 +232,6 @@ ecma_op_get_binding_value (ecma_object_t *lex_env_p, /**< lexical environment */
&& ecma_is_lexical_environment (lex_env_p)); && ecma_is_lexical_environment (lex_env_p));
JERRY_ASSERT(name_p != NULL); JERRY_ASSERT(name_p != NULL);
JERRY_ASSERT(ecma_op_has_binding (lex_env_p, name_p));
switch (ecma_get_lex_env_type (lex_env_p)) switch (ecma_get_lex_env_type (lex_env_p))
{ {
case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE: case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE:
@@ -422,8 +416,6 @@ ecma_op_create_immutable_binding (ecma_object_t *lex_env_p, /**< lexical environ
{ {
case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE: case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE:
{ {
JERRY_ASSERT(!ecma_op_has_binding (lex_env_p, name_p));
/* /*
* Warning: * Warning:
* Whether immutable bindings are deletable seems not to be defined by ECMA v5. * Whether immutable bindings are deletable seems not to be defined by ECMA v5.
@@ -466,8 +458,6 @@ ecma_op_initialize_immutable_binding (ecma_object_t *lex_env_p, /**< lexical env
{ {
case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE: case ECMA_LEXICAL_ENVIRONMENT_DECLARATIVE:
{ {
JERRY_ASSERT(ecma_op_has_binding (lex_env_p, name_p));
ecma_property_t *prop_p = ecma_get_named_data_property (lex_env_p, name_p); ecma_property_t *prop_p = ecma_get_named_data_property (lex_env_p, name_p);
/* The binding must be unitialized immutable binding */ /* The binding must be unitialized immutable binding */