From 71e1383d13fc5814ecf1f493117060ec869b8369 Mon Sep 17 00:00:00 2001 From: Zidong Jiang Date: Mon, 6 Mar 2017 21:08:30 +0800 Subject: [PATCH] Check if propery is not found before delete it. (#1637) Fix issue #1633 JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang zidong.jiang@intel.com --- jerry-core/ecma/operations/ecma-objects-general.c | 2 +- tests/jerry/es2015/regression-test-issue-1633.js | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/es2015/regression-test-issue-1633.js diff --git a/jerry-core/ecma/operations/ecma-objects-general.c b/jerry-core/ecma/operations/ecma-objects-general.c index 5735feeaf..faa6d92bf 100644 --- a/jerry-core/ecma/operations/ecma-objects-general.c +++ b/jerry-core/ecma/operations/ecma-objects-general.c @@ -155,7 +155,7 @@ ecma_op_general_object_delete (ecma_object_t *obj_p, /**< the object */ ECMA_PROPERTY_GET_NO_OPTIONS); /* 2. */ - if (property == ECMA_PROPERTY_TYPE_NOT_FOUND && property != ECMA_PROPERTY_TYPE_NOT_FOUND_AND_STOP) + if (property == ECMA_PROPERTY_TYPE_NOT_FOUND || property == ECMA_PROPERTY_TYPE_NOT_FOUND_AND_STOP) { return ecma_make_simple_value (ECMA_SIMPLE_VALUE_TRUE); } diff --git a/tests/jerry/es2015/regression-test-issue-1633.js b/tests/jerry/es2015/regression-test-issue-1633.js new file mode 100644 index 000000000..60355b7c7 --- /dev/null +++ b/tests/jerry/es2015/regression-test-issue-1633.js @@ -0,0 +1,15 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +delete new Uint16Array()[0]