From 70383255fc78724d537bff783a98b31811b4996f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1niel=20B=C3=A1tyai?= Date: Tue, 9 Jun 2020 07:27:31 +0200 Subject: [PATCH] Fix result of Date getters when called on invalid date (#3879) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #3878. JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu --- .../ecma-builtin-date-prototype.c | 2 +- tests/jerry/regression-test-issue-3878.js | 21 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/regression-test-issue-3878.js diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c b/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c index a887549fd..d80d15f1a 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c @@ -237,7 +237,7 @@ ecma_builtin_date_prototype_dispatch_get (uint16_t builtin_routine_id, /**< buil { if (ecma_number_is_nan (date_num)) { - return ecma_make_magic_string_value (LIT_MAGIC_STRING_NAN); + return ecma_make_nan_value (); } switch (builtin_routine_id) diff --git a/tests/jerry/regression-test-issue-3878.js b/tests/jerry/regression-test-issue-3878.js new file mode 100644 index 000000000..21afd23fa --- /dev/null +++ b/tests/jerry/regression-test-issue-3878.js @@ -0,0 +1,21 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +var d = new Date(); + +var s = d.setHours(); +assert (typeof s === "number" && isNaN (s)); + +var g = d.getHours(); +assert (typeof g === "number" && isNaN (g));