YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add parameter names to function declarations. (#1498)

Browse Source 
It's generally considered a bad programming practice to have function declarations without parameter names.

This is another legacy from the early days of the project. Fix in one go to minimize history disruption.

Used a custom clang-tidy check to create the bulk of the change.

JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller t.scheller@samsung.com
This commit is contained in:
Tilmann Scheller
2016-12-16 15:40:46 +01:00
committed by GitHub
parent 1e99be90c3
commit 65c32f6a3b
45 changed files with 666 additions and 612 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/vm/opcodes.h
+20 -20
View File
@@ -52,64 +52,64 @@ typedef enum
} number_bitwise_logic_op;
ecma_value_t
vm_var_decl (vm_frame_ctx_t *, ecma_string_t *);
vm_var_decl (vm_frame_ctx_t *frame_ctx_p, ecma_string_t *var_name_str_p);
ecma_value_t
opfunc_equal_value (ecma_value_t, ecma_value_t);
opfunc_equal_value (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_not_equal_value (ecma_value_t, ecma_value_t);
opfunc_not_equal_value (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
do_number_arithmetic (number_arithmetic_op, ecma_value_t, ecma_value_t);
do_number_arithmetic (number_arithmetic_op op, ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_unary_plus (ecma_value_t);
opfunc_unary_plus (ecma_value_t left_value);
ecma_value_t
opfunc_unary_minus (ecma_value_t);
opfunc_unary_minus (ecma_value_t left_value);
ecma_value_t
do_number_bitwise_logic (number_bitwise_logic_op, ecma_value_t, ecma_value_t);
do_number_bitwise_logic (number_bitwise_logic_op op, ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_addition (ecma_value_t, ecma_value_t);
opfunc_addition (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_less_than (ecma_value_t, ecma_value_t);
opfunc_less_than (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_greater_than (ecma_value_t, ecma_value_t);
opfunc_greater_than (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_less_or_equal_than (ecma_value_t, ecma_value_t);
opfunc_less_or_equal_than (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_greater_or_equal_than (ecma_value_t, ecma_value_t);
opfunc_greater_or_equal_than (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_in (ecma_value_t, ecma_value_t);
opfunc_in (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_instanceof (ecma_value_t, ecma_value_t);
opfunc_instanceof (ecma_value_t left_value, ecma_value_t right_value);
ecma_value_t
opfunc_logical_not (ecma_value_t);
opfunc_logical_not (ecma_value_t left_value);
ecma_value_t
opfunc_typeof (ecma_value_t);
opfunc_typeof (ecma_value_t left_value);
void
opfunc_set_accessor (bool, ecma_value_t, ecma_value_t, ecma_value_t);
opfunc_set_accessor (bool is_getter, ecma_value_t object, ecma_value_t accessor_name, ecma_value_t accessor);
ecma_value_t
vm_op_delete_prop (ecma_value_t, ecma_value_t, bool);
vm_op_delete_prop (ecma_value_t object, ecma_value_t property, bool is_strict);
ecma_value_t
vm_op_delete_var (jmem_cpointer_t, ecma_object_t *);
vm_op_delete_var (jmem_cpointer_t name_literal, ecma_object_t *lex_env_p);
ecma_collection_header_t *
opfunc_for_in (ecma_value_t, ecma_value_t *);
opfunc_for_in (ecma_value_t left_value, ecma_value_t *result_obj_p);
/**
* @}
jerry-core/vm/vm-stack.h
+3 -3
View File
@@ -66,9 +66,9 @@ typedef enum
VM_CONTEXT_FOR_IN, /**< for-in context */
} vm_stack_context_type_t;
ecma_value_t *vm_stack_context_abort (vm_frame_ctx_t *, ecma_value_t *);
bool vm_stack_find_finally (vm_frame_ctx_t *, ecma_value_t **,
vm_stack_context_type_t, uint32_t);
ecma_value_t *vm_stack_context_abort (vm_frame_ctx_t *frame_ctx_p, ecma_value_t *vm_stack_top_p);
bool vm_stack_find_finally (vm_frame_ctx_t *frame_ctx_p, ecma_value_t **vm_stack_top_ref_p,
vm_stack_context_type_t finally_type, uint32_t search_limit);
/**
* @}
jerry-core/vm/vm.h
+5 -5
View File
@@ -274,12 +274,12 @@ typedef enum
VM_EXEC_CONSTRUCT, /**< construct a new object */
} vm_call_operation;
ecma_value_t vm_run_global (const ecma_compiled_code_t *);
ecma_value_t vm_run_eval (ecma_compiled_code_t *, bool);
ecma_value_t vm_run_global (const ecma_compiled_code_t *bytecode_p);
ecma_value_t vm_run_eval (ecma_compiled_code_t *bytecode_data_p, bool is_direct);
ecma_value_t vm_run (const ecma_compiled_code_t *, ecma_value_t,
ecma_object_t *, bool, const ecma_value_t *,
ecma_length_t);
ecma_value_t vm_run (const ecma_compiled_code_t *bytecode_header_p, ecma_value_t this_binding_value,
ecma_object_t *lex_env_p, bool is_eval_code, const ecma_value_t *arg_list_p,
ecma_length_t arg_list_len);
bool vm_is_strict_mode (void);
bool vm_is_direct_eval_form_call (void);