YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add parameter names to function declarations. (#1498)

Browse Source 
It's generally considered a bad programming practice to have function declarations without parameter names.

This is another legacy from the early days of the project. Fix in one go to minimize history disruption.

Used a custom clang-tidy check to create the bulk of the change.

JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller t.scheller@samsung.com
This commit is contained in:
Tilmann Scheller
2016-12-16 15:40:46 +01:00
committed by GitHub
parent 1e99be90c3
commit 65c32f6a3b
45 changed files with 666 additions and 612 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/operations/ecma-array-object.h
+8 -5
View File
@@ -40,17 +40,20 @@ typedef enum
} ecma_array_object_set_length_flags_t;
ecma_value_t
ecma_op_create_array_object (const ecma_value_t *, ecma_length_t, bool);
ecma_op_create_array_object (const ecma_value_t *arguments_list_p, ecma_length_t arguments_list_len,
bool is_treat_single_arg_as_length);
ecma_value_t
ecma_op_array_object_set_length (ecma_object_t *, ecma_value_t, uint32_t);
ecma_op_array_object_set_length (ecma_object_t *object_p, ecma_value_t new_value, uint32_t flags);
ecma_value_t
ecma_op_array_object_define_own_property (ecma_object_t *, ecma_string_t *, const ecma_property_descriptor_t *, bool);
ecma_op_array_object_define_own_property (ecma_object_t *object_p, ecma_string_t *property_name_p,
const ecma_property_descriptor_t *property_desc_p, bool is_throw);
void
ecma_op_array_list_lazy_property_names (ecma_object_t *, bool,
ecma_collection_header_t *, ecma_collection_header_t *);
ecma_op_array_list_lazy_property_names (ecma_object_t *obj_p, bool separate_enumerable,
ecma_collection_header_t *main_collection_p,
ecma_collection_header_t *non_enum_collection_p);
/**
* @}
jerry-core/ecma/operations/ecma-boolean-object.h
+1 -1
View File
@@ -25,7 +25,7 @@
* @{
*/
ecma_value_t ecma_op_create_boolean_object (ecma_value_t);
ecma_value_t ecma_op_create_boolean_object (ecma_value_t arg);
/**
* @}
jerry-core/ecma/operations/ecma-comparison.h
+3 -3
View File
@@ -26,9 +26,9 @@
* @{
*/
ecma_value_t ecma_op_abstract_equality_compare (ecma_value_t, ecma_value_t);
bool ecma_op_strict_equality_compare (ecma_value_t, ecma_value_t);
ecma_value_t ecma_op_abstract_relational_compare (ecma_value_t, ecma_value_t, bool);
ecma_value_t ecma_op_abstract_equality_compare (ecma_value_t x, ecma_value_t y);
bool ecma_op_strict_equality_compare (ecma_value_t x, ecma_value_t y);
ecma_value_t ecma_op_abstract_relational_compare (ecma_value_t x, ecma_value_t y, bool left_first);
/**
* @}
jerry-core/ecma/operations/ecma-conversion.h
+9 -9
View File
@@ -37,16 +37,16 @@ typedef enum
ECMA_PREFERRED_TYPE_STRING /**< String */
} ecma_preferred_type_hint_t;
ecma_value_t ecma_op_check_object_coercible (ecma_value_t);
bool ecma_op_same_value (ecma_value_t, ecma_value_t);
ecma_value_t ecma_op_to_primitive (ecma_value_t, ecma_preferred_type_hint_t);
bool ecma_op_to_boolean (ecma_value_t);
ecma_value_t ecma_op_to_number (ecma_value_t);
ecma_value_t ecma_op_to_string (ecma_value_t);
ecma_value_t ecma_op_to_object (ecma_value_t);
ecma_value_t ecma_op_check_object_coercible (ecma_value_t value);
bool ecma_op_same_value (ecma_value_t x, ecma_value_t y);
ecma_value_t ecma_op_to_primitive (ecma_value_t value, ecma_preferred_type_hint_t preferred_type);
bool ecma_op_to_boolean (ecma_value_t value);
ecma_value_t ecma_op_to_number (ecma_value_t value);
ecma_value_t ecma_op_to_string (ecma_value_t value);
ecma_value_t ecma_op_to_object (ecma_value_t value);
ecma_object_t *ecma_op_from_property_descriptor (const ecma_property_descriptor_t *);
ecma_value_t ecma_op_to_property_descriptor (ecma_value_t, ecma_property_descriptor_t *);
ecma_object_t *ecma_op_from_property_descriptor (const ecma_property_descriptor_t *src_prop_desc_p);
ecma_value_t ecma_op_to_property_descriptor (ecma_value_t obj_value, ecma_property_descriptor_t *out_prop_desc_p);
/**
* @}
jerry-core/ecma/operations/ecma-eval.h
+3 -2
View File
@@ -26,10 +26,11 @@
*/
ecma_value_t
ecma_op_eval (ecma_string_t *, bool, bool);
ecma_op_eval (ecma_string_t *code_p, bool is_direct, bool is_called_from_strict_mode_code);
ecma_value_t
ecma_op_eval_chars_buffer (const lit_utf8_byte_t *, size_t, bool, bool);
ecma_op_eval_chars_buffer (const lit_utf8_byte_t *code_p, size_t code_buffer_size, bool is_direct,
bool is_called_from_strict_mode_code);
/**
* @}
jerry-core/ecma/operations/ecma-exceptions.h
+10 -10
View File
@@ -48,16 +48,16 @@ typedef enum
ECMA_ERROR_URI /**< URIError */
} ecma_standard_error_t;
ecma_object_t *ecma_new_standard_error (ecma_standard_error_t);
ecma_object_t *ecma_new_standard_error_with_message (ecma_standard_error_t, ecma_string_t *);
ecma_value_t ecma_raise_standard_error (ecma_standard_error_t, const lit_utf8_byte_t *);
ecma_value_t ecma_raise_common_error (const char *);
ecma_value_t ecma_raise_eval_error (const char *);
ecma_value_t ecma_raise_range_error (const char *);
ecma_value_t ecma_raise_reference_error (const char *);
ecma_value_t ecma_raise_syntax_error (const char *);
ecma_value_t ecma_raise_type_error (const char *);
ecma_value_t ecma_raise_uri_error (const char *);
ecma_object_t *ecma_new_standard_error (ecma_standard_error_t error_type);
ecma_object_t *ecma_new_standard_error_with_message (ecma_standard_error_t error_type, ecma_string_t *message_string_p);
ecma_value_t ecma_raise_standard_error (ecma_standard_error_t error_type, const lit_utf8_byte_t *msg_p);
ecma_value_t ecma_raise_common_error (const char *msg_p);
ecma_value_t ecma_raise_eval_error (const char *msg_p);
ecma_value_t ecma_raise_range_error (const char *msg_p);
ecma_value_t ecma_raise_reference_error (const char *msg_p);
ecma_value_t ecma_raise_syntax_error (const char *msg_p);
ecma_value_t ecma_raise_type_error (const char *msg_p);
ecma_value_t ecma_raise_uri_error (const char *msg_p);
/**
* @}
jerry-core/ecma/operations/ecma-function-object.h
+14 -12
View File
@@ -26,32 +26,34 @@
* @{
*/
bool ecma_op_is_callable (ecma_value_t);
bool ecma_is_constructor (ecma_value_t);
bool ecma_op_is_callable (ecma_value_t value);
bool ecma_is_constructor (ecma_value_t value);
ecma_object_t *
ecma_op_create_function_object (ecma_object_t *, bool, const ecma_compiled_code_t *);
ecma_op_create_function_object (ecma_object_t *scope_p, bool is_decl_in_strict_mode,
const ecma_compiled_code_t *bytecode_data_p);
void
ecma_op_function_list_lazy_property_names (bool,
ecma_collection_header_t *,
ecma_collection_header_t *);
ecma_op_function_list_lazy_property_names (bool separate_enumerable,
ecma_collection_header_t *main_collection_p,
ecma_collection_header_t *non_enum_collection_p);
ecma_property_t *
ecma_op_function_try_lazy_instantiate_property (ecma_object_t *, ecma_string_t *);
ecma_op_function_try_lazy_instantiate_property (ecma_object_t *object_p, ecma_string_t *property_name_p);
ecma_object_t *
ecma_op_create_external_function_object (ecma_external_pointer_t);
ecma_op_create_external_function_object (ecma_external_pointer_t code_p);
ecma_value_t
ecma_op_function_call (ecma_object_t *, ecma_value_t,
const ecma_value_t *, ecma_length_t);
ecma_op_function_call (ecma_object_t *func_obj_p, ecma_value_t this_arg_value,
const ecma_value_t *arguments_list_p, ecma_length_t arguments_list_len);
ecma_value_t
ecma_op_function_construct (ecma_object_t *, const ecma_value_t *, ecma_length_t);
ecma_op_function_construct (ecma_object_t *func_obj_p, const ecma_value_t *arguments_list_p,
ecma_length_t arguments_list_len);
ecma_value_t
ecma_op_function_has_instance (ecma_object_t *, ecma_value_t);
ecma_op_function_has_instance (ecma_object_t *func_obj_p, ecma_value_t value);
/**
* @}
jerry-core/ecma/operations/ecma-lex-env.h
+13 -10
View File
@@ -39,20 +39,23 @@ ecma_object_t *ecma_get_global_environment (void);
*/
/* ECMA-262 v5, 8.7.1 and 8.7.2 */
ecma_value_t ecma_op_get_value_lex_env_base (ecma_object_t *, ecma_string_t *, bool);
ecma_value_t ecma_op_get_value_object_base (ecma_value_t, ecma_string_t *);
ecma_value_t ecma_op_put_value_lex_env_base (ecma_object_t *, ecma_string_t *, bool, ecma_value_t);
ecma_value_t ecma_op_get_value_lex_env_base (ecma_object_t *ref_base_lex_env_p, ecma_string_t *var_name_string_p,
bool is_strict);
ecma_value_t ecma_op_get_value_object_base (ecma_value_t base_value, ecma_string_t *property_name_p);
ecma_value_t ecma_op_put_value_lex_env_base (ecma_object_t *ref_base_lex_env_p, ecma_string_t *var_name_string_p,
bool is_strict, ecma_value_t value);
/* ECMA-262 v5, Table 17. Abstract methods of Environment Records */
bool ecma_op_has_binding (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_create_mutable_binding (ecma_object_t *, ecma_string_t *, bool);
ecma_value_t ecma_op_set_mutable_binding (ecma_object_t *, ecma_string_t *, ecma_value_t, bool);
ecma_value_t ecma_op_get_binding_value (ecma_object_t *, ecma_string_t *, bool);
ecma_value_t ecma_op_delete_binding (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_implicit_this_value (ecma_object_t *);
bool ecma_op_has_binding (ecma_object_t *lex_env_p, ecma_string_t *name_p);
ecma_value_t ecma_op_create_mutable_binding (ecma_object_t *lex_env_p, ecma_string_t *name_p, bool is_deletable);
ecma_value_t ecma_op_set_mutable_binding (ecma_object_t *lex_env_p, ecma_string_t *name_p, ecma_value_t value,
bool is_strict);
ecma_value_t ecma_op_get_binding_value (ecma_object_t *lex_env_p, ecma_string_t *name_p, bool is_strict);
ecma_value_t ecma_op_delete_binding (ecma_object_t *lex_env_p, ecma_string_t *name_p);
ecma_value_t ecma_op_implicit_this_value (ecma_object_t *lex_env_p);
/* ECMA-262 v5, Table 18. Additional methods of Declarative Environment Records */
void ecma_op_create_immutable_binding (ecma_object_t *, ecma_string_t *, ecma_value_t);
void ecma_op_create_immutable_binding (ecma_object_t *lex_env_p, ecma_string_t *name_p, ecma_value_t value);
ecma_object_t *ecma_op_create_global_environment (ecma_object_t *);
jerry-core/ecma/operations/ecma-number-arithmetic.h
+1 -1
View File
@@ -25,7 +25,7 @@
* @{
*/
ecma_number_t ecma_op_number_remainder (ecma_number_t, ecma_number_t);
ecma_number_t ecma_op_number_remainder (ecma_number_t left_num, ecma_number_t right_num);
/**
* @}
jerry-core/ecma/operations/ecma-number-object.h
+1 -1
View File
@@ -25,7 +25,7 @@
* @{
*/
ecma_value_t ecma_op_create_number_object (ecma_value_t);
ecma_value_t ecma_op_create_number_object (ecma_value_t arg);
/**
* @}
jerry-core/ecma/operations/ecma-objects-arguments.h
+6 -5
View File
@@ -20,13 +20,14 @@
#include "ecma-helpers.h"
void
ecma_op_create_arguments_object (ecma_object_t *, ecma_object_t *, const ecma_value_t *,
ecma_length_t, const ecma_compiled_code_t *);
ecma_op_create_arguments_object (ecma_object_t *func_obj_p, ecma_object_t *lex_env_p,
const ecma_value_t *arguments_list_p, ecma_length_t arguments_number,
const ecma_compiled_code_t *bytecode_data_p);
ecma_value_t
ecma_op_arguments_object_delete (ecma_object_t *, ecma_string_t *, bool);
ecma_op_arguments_object_delete (ecma_object_t *object_p, ecma_string_t *property_name_p, bool is_throw);
ecma_value_t
ecma_op_arguments_object_define_own_property (ecma_object_t *, ecma_string_t *,
const ecma_property_descriptor_t *, bool);
ecma_op_arguments_object_define_own_property (ecma_object_t *object_p, ecma_string_t *property_name_p,
const ecma_property_descriptor_t *property_desc_p, bool is_throw);
#endif /* !ECMA_OBJECTS_ARGUMENTS_H */
jerry-core/ecma/operations/ecma-objects-general.h
+8 -7
View File
@@ -26,15 +26,16 @@
* @{
*/
ecma_value_t ecma_reject (bool);
ecma_value_t ecma_reject (bool is_throw);
ecma_object_t *ecma_op_create_object_object_noarg (void);
ecma_value_t ecma_op_create_object_object_arg (ecma_value_t);
ecma_object_t *ecma_op_create_object_object_noarg_and_set_prototype (ecma_object_t *);
ecma_value_t ecma_op_create_object_object_arg (ecma_value_t value);
ecma_object_t *ecma_op_create_object_object_noarg_and_set_prototype (ecma_object_t *object_prototype_p);
ecma_value_t ecma_op_general_object_delete (ecma_object_t *, ecma_string_t *, bool);
ecma_value_t ecma_op_general_object_default_value (ecma_object_t *, ecma_preferred_type_hint_t);
ecma_value_t ecma_op_general_object_define_own_property (ecma_object_t *, ecma_string_t *,
const ecma_property_descriptor_t *, bool);
ecma_value_t ecma_op_general_object_delete (ecma_object_t *obj_p, ecma_string_t *property_name_p, bool is_throw);
ecma_value_t ecma_op_general_object_default_value (ecma_object_t *obj_p, ecma_preferred_type_hint_t hint);
ecma_value_t ecma_op_general_object_define_own_property (ecma_object_t *object_p, ecma_string_t *property_name_p,
const ecma_property_descriptor_t *property_desc_p,
bool is_throw);
/**
* @}
jerry-core/ecma/operations/ecma-objects.h
+24 -22
View File
@@ -26,29 +26,31 @@
* @{
*/
ecma_property_t ecma_op_object_get_own_property (ecma_object_t *, ecma_string_t *,
ecma_property_ref_t *, uint32_t);
ecma_property_t ecma_op_object_get_property (ecma_object_t *, ecma_string_t *,
ecma_property_ref_t *, uint32_t);
bool ecma_op_object_has_own_property (ecma_object_t *, ecma_string_t *);
bool ecma_op_object_has_property (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_object_find_own (ecma_value_t, ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_object_find (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_object_get_own_data_prop (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_object_get (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_object_put (ecma_object_t *, ecma_string_t *, ecma_value_t, bool);
ecma_value_t ecma_op_object_delete (ecma_object_t *, ecma_string_t *, bool);
ecma_value_t ecma_op_object_default_value (ecma_object_t *, ecma_preferred_type_hint_t);
ecma_value_t ecma_op_object_define_own_property (ecma_object_t *, ecma_string_t *,
const ecma_property_descriptor_t *, bool);
bool ecma_op_object_get_own_property_descriptor (ecma_object_t *, ecma_string_t *,
ecma_property_descriptor_t *);
ecma_value_t ecma_op_object_has_instance (ecma_object_t *, ecma_value_t);
bool ecma_op_object_is_prototype_of (ecma_object_t *, ecma_object_t *);
ecma_collection_header_t * ecma_op_object_get_property_names (ecma_object_t *, bool, bool, bool);
ecma_property_t ecma_op_object_get_own_property (ecma_object_t *object_p, ecma_string_t *property_name_p,
ecma_property_ref_t *property_ref_p, uint32_t options);
ecma_property_t ecma_op_object_get_property (ecma_object_t *object_p, ecma_string_t *property_name_p,
ecma_property_ref_t *property_ref_p, uint32_t options);
bool ecma_op_object_has_own_property (ecma_object_t *object_p, ecma_string_t *property_name_p);
bool ecma_op_object_has_property (ecma_object_t *object_p, ecma_string_t *property_name_p);
ecma_value_t ecma_op_object_find_own (ecma_value_t base_value, ecma_object_t *object_p, ecma_string_t *property_name_p);
ecma_value_t ecma_op_object_find (ecma_object_t *object_p, ecma_string_t *property_name_p);
ecma_value_t ecma_op_object_get_own_data_prop (ecma_object_t *object_p, ecma_string_t *property_name_p);
ecma_value_t ecma_op_object_get (ecma_object_t *object_p, ecma_string_t *property_name_p);
ecma_value_t ecma_op_object_put (ecma_object_t *object_p, ecma_string_t *property_name_p, ecma_value_t value,
bool is_throw);
ecma_value_t ecma_op_object_delete (ecma_object_t *obj_p, ecma_string_t *property_name_p, bool is_throw);
ecma_value_t ecma_op_object_default_value (ecma_object_t *obj_p, ecma_preferred_type_hint_t hint);
ecma_value_t ecma_op_object_define_own_property (ecma_object_t *obj_p, ecma_string_t *property_name_p,
const ecma_property_descriptor_t *property_desc_p, bool is_throw);
bool ecma_op_object_get_own_property_descriptor (ecma_object_t *object_p, ecma_string_t *property_name_p,
ecma_property_descriptor_t *prop_desc_p);
ecma_value_t ecma_op_object_has_instance (ecma_object_t *obj_p, ecma_value_t value);
bool ecma_op_object_is_prototype_of (ecma_object_t *base_p, ecma_object_t *target_p);
ecma_collection_header_t * ecma_op_object_get_property_names (ecma_object_t *obj_p, bool is_array_indices_only,
bool is_enumerable_only, bool is_with_prototype_chain);
lit_magic_string_id_t ecma_object_get_class_name (ecma_object_t *);
bool ecma_object_class_is (ecma_object_t *, uint32_t);
lit_magic_string_id_t ecma_object_get_class_name (ecma_object_t *obj_p);
bool ecma_object_class_is (ecma_object_t *object_p, uint32_t class_id);
/**
* @}
jerry-core/ecma/operations/ecma-reference.h
+2 -2
View File
@@ -26,8 +26,8 @@
* @{
*/
ecma_object_t *ecma_op_resolve_reference_base (ecma_object_t *, ecma_string_t *);
ecma_value_t ecma_op_resolve_reference_value (ecma_object_t *, ecma_string_t *);
ecma_object_t *ecma_op_resolve_reference_base (ecma_object_t *lex_env_p, ecma_string_t *name_p);
ecma_value_t ecma_op_resolve_reference_value (ecma_object_t *lex_env_p, ecma_string_t *name_p);
/**
* @}
jerry-core/ecma/operations/ecma-regexp-object.h
+8 -7
View File
@@ -52,13 +52,14 @@ typedef struct
uint16_t flags; /**< RegExp flags */
} re_matcher_ctx_t;
ecma_value_t ecma_op_create_regexp_object_from_bytecode (re_compiled_code_t *);
ecma_value_t ecma_op_create_regexp_object (ecma_string_t *, ecma_string_t *);
ecma_value_t ecma_regexp_exec_helper (ecma_value_t, ecma_value_t, bool);
ecma_char_t re_canonicalize (ecma_char_t, bool);
void re_set_result_array_properties (ecma_object_t *, ecma_string_t *, uint32_t, int32_t);
ecma_value_t re_parse_regexp_flags (ecma_string_t *, uint16_t *);
void re_initialize_props (ecma_object_t *, ecma_string_t *, uint16_t);
ecma_value_t ecma_op_create_regexp_object_from_bytecode (re_compiled_code_t *bytecode_p);
ecma_value_t ecma_op_create_regexp_object (ecma_string_t *pattern_p, ecma_string_t *flags_str_p);
ecma_value_t ecma_regexp_exec_helper (ecma_value_t regexp_value, ecma_value_t input_string, bool ignore_global);
ecma_char_t re_canonicalize (ecma_char_t ch, bool is_ignorecase);
void re_set_result_array_properties (ecma_object_t *array_obj_p, ecma_string_t *input_str_p, uint32_t num_of_elements,
int32_t index);
ecma_value_t re_parse_regexp_flags (ecma_string_t *flags_str_p, uint16_t *flags_p);
void re_initialize_props (ecma_object_t *re_obj_p, ecma_string_t *source_p, uint16_t flags);
/**
* @}
jerry-core/ecma/operations/ecma-string-object.h
+5 -5
View File
@@ -26,13 +26,13 @@
*/
ecma_value_t
ecma_op_create_string_object (const ecma_value_t *, ecma_length_t);
ecma_op_create_string_object (const ecma_value_t *arguments_list_p, ecma_length_t arguments_list_len);
void
ecma_op_string_list_lazy_property_names (ecma_object_t *,
bool,
ecma_collection_header_t *,
ecma_collection_header_t *);
ecma_op_string_list_lazy_property_names (ecma_object_t *obj_p,
bool separate_enumerable,
ecma_collection_header_t *main_collection_p,
ecma_collection_header_t *non_enum_collection_p);
/**