YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add jerryscript-compiler.h public header to cover compiler incompatibilities (#2313)

Browse Source 
In general, public headers should not have compiler-specific
constructs but both the core and the port headers have attributes,
which are non-standard. It's better to factor out such constructs
to a common place (a new header) and hide them behind macros, which
can then be defined on a per-compiler basis.

This patch moves the existing definitions of function attributes and
likely/unlikely builtins to the new header. At the same time, it
unifies the names of these attribute defines and where they are
used. Moreover, it touches on jerry-main and removes the uses of
`__attribute__((unused))` entirely and replaces them with the
elsewhere used `(void) ...` pattern.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
This commit is contained in:
Akos Kiss
2018-05-14 02:41:26 +02:00
committed by yichoi
parent 0e131da4f7
commit 65ae949dc3
58 changed files with 433 additions and 340 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.c
+1 -1
View File
@@ -551,7 +551,7 @@ ecma_builtin_date_prototype_dispatch_routine (uint16_t builtin_routine_id, /**<
* passed to routine */
ecma_length_t arguments_number) /**< length of arguments' list */
{
if (unlikely (builtin_routine_id == ECMA_DATE_PROTOTYPE_TO_JSON))
if (JERRY_UNLIKELY (builtin_routine_id == ECMA_DATE_PROTOTYPE_TO_JSON))
{
return ecma_builtin_date_prototype_to_json (this_arg);
}
jerry-core/ecma/builtin-objects/ecma-builtin-error-prototype.c
+2 -2
View File
@@ -81,7 +81,7 @@ ecma_builtin_error_prototype_object_to_string (ecma_value_t this_arg) /**< this
name_to_str_completion = ecma_op_to_string (name_get_ret_value);
}
if (unlikely (ECMA_IS_VALUE_ERROR (name_to_str_completion)))
if (JERRY_UNLIKELY (ECMA_IS_VALUE_ERROR (name_to_str_completion)))
{
ret_value = ecma_copy_value (name_to_str_completion);
}
@@ -102,7 +102,7 @@ ecma_builtin_error_prototype_object_to_string (ecma_value_t this_arg) /**< this
msg_to_str_completion = ecma_op_to_string (msg_get_ret_value);
}
if (unlikely (ECMA_IS_VALUE_ERROR (msg_to_str_completion)))
if (JERRY_UNLIKELY (ECMA_IS_VALUE_ERROR (msg_to_str_completion)))
{
ret_value = ecma_copy_value (msg_to_str_completion);
}
jerry-core/ecma/builtin-objects/ecma-builtin-helpers-date.c
+7 -7
View File
@@ -41,7 +41,7 @@
*
* @return time value for day number
*/
inline ecma_number_t __attr_always_inline___
inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_day (ecma_number_t time) /**< time value */
{
JERRY_ASSERT (!ecma_number_is_nan (time));
@@ -57,7 +57,7 @@ ecma_date_day (ecma_number_t time) /**< time value */
*
* @return time value within the day
*/
inline ecma_number_t __attr_always_inline___
inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_time_within_day (ecma_number_t time) /**< time value */
{
JERRY_ASSERT (!ecma_number_is_nan (time));
@@ -92,7 +92,7 @@ ecma_date_day_from_year (ecma_number_t year) /**< year value */
*
* @return time value of the start of a year
*/
static inline ecma_number_t __attr_always_inline___
static inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_time_from_year (ecma_number_t year) /**< year value */
{
JERRY_ASSERT (!ecma_number_is_nan (year));
@@ -309,7 +309,7 @@ ecma_date_week_day (ecma_number_t time) /**< time value */
*
* @return local time zone adjustment
*/
static inline ecma_number_t __attr_always_inline___
static inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_local_tza (jerry_time_zone_t *tz) /**< time zone information */
{
return tz->offset * -ECMA_DATE_MS_PER_MINUTE;
@@ -323,7 +323,7 @@ ecma_date_local_tza (jerry_time_zone_t *tz) /**< time zone information */
*
* @return daylight saving time adjustment
*/
static inline ecma_number_t __attr_always_inline___
static inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_daylight_saving_ta (jerry_time_zone_t *tz, /**< time zone information */
ecma_number_t time) /**< time value */
{
@@ -344,7 +344,7 @@ ecma_date_daylight_saving_ta (jerry_time_zone_t *tz, /**< time zone information
*
* @return local time
*/
inline ecma_number_t __attr_always_inline___
inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_local_time_zone (ecma_number_t time) /**< time value */
{
jerry_time_zone_t tz;
@@ -610,7 +610,7 @@ ecma_date_time_clip (ecma_number_t time) /**< time value */
*
* @return timezone offset
*/
inline ecma_number_t __attr_always_inline___
inline ecma_number_t JERRY_ATTR_ALWAYS_INLINE
ecma_date_timezone_offset (ecma_number_t time) /**< time value */
{
JERRY_ASSERT (!ecma_number_is_nan (time));
jerry-core/ecma/builtin-objects/ecma-builtin-helpers-json.c
+1 -1
View File
@@ -115,7 +115,7 @@ ecma_builtin_helper_json_create_separated_properties (ecma_collection_header_t *
ecma_string_t *current_p = ecma_get_string_from_value (*ecma_value_p);
ecma_value_p = ecma_collection_iterator_next (ecma_value_p);
if (likely (!first))
if (JERRY_LIKELY (!first))
{
properties_str_p = ecma_concat_ecma_strings (properties_str_p, separator_p);
}
jerry-core/ecma/builtin-objects/ecma-builtin-math.c
+1 -1
View File
@@ -122,7 +122,7 @@ ecma_builtin_math_object_max_min (bool is_max, /**< 'max' or 'min' operation */
ecma_fast_free_value (value);
}
if (unlikely (ecma_number_is_nan (arg_num)))
if (JERRY_UNLIKELY (ecma_number_is_nan (arg_num)))
{
result_num = arg_num;
break;
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.c
+2 -2
View File
@@ -125,7 +125,7 @@ ecma_builtin_number_prototype_helper_to_string (lit_utf8_byte_t *digits_p, /**<
return (lit_utf8_size_t) (p - to_digits_p);
} /* ecma_builtin_number_prototype_helper_to_string */
static inline lit_utf8_size_t __attr_always_inline___
static inline lit_utf8_size_t JERRY_ATTR_ALWAYS_INLINE
ecma_builtin_binary_floating_number_to_string (lit_utf8_byte_t *digits_p, /**< number as string
* in binary-floating point number */
int32_t exponent, /**< decimal exponent */
@@ -164,7 +164,7 @@ ecma_builtin_binary_floating_number_to_string (lit_utf8_byte_t *digits_p, /**< n
*
* @return rounded number
*/
static inline lit_utf8_size_t __attr_always_inline___
static inline lit_utf8_size_t JERRY_ATTR_ALWAYS_INLINE
ecma_builtin_number_prototype_helper_round (lit_utf8_byte_t *digits_p, /**< [in,out] number as a string in decimal
* form */
lit_utf8_size_t num_digits, /**< length of the string representation */
jerry-core/ecma/builtin-objects/ecma-builtins.c
+3 -3
View File
@@ -177,7 +177,7 @@ ecma_builtin_get (ecma_builtin_id_t builtin_id) /**< id of built-in to check on
{
JERRY_ASSERT (builtin_id < ECMA_BUILTIN_ID__COUNT);
if (unlikely (JERRY_CONTEXT (ecma_builtin_objects)[builtin_id] == NULL))
if (JERRY_UNLIKELY (JERRY_CONTEXT (ecma_builtin_objects)[builtin_id] == NULL))
{
ecma_instantiate_builtin (builtin_id);
}
@@ -193,7 +193,7 @@ ecma_builtin_get (ecma_builtin_id_t builtin_id) /**< id of built-in to check on
* @return true - if the function object is a built-in routine
* false - otherwise
*/
inline bool __attr_always_inline___
inline bool JERRY_ATTR_ALWAYS_INLINE
ecma_builtin_function_is_routine (ecma_object_t *func_obj_p) /**< function object */
{
JERRY_ASSERT (ecma_get_object_type (func_obj_p) == ECMA_OBJECT_TYPE_FUNCTION);
@@ -233,7 +233,7 @@ ecma_builtin_init_object (ecma_builtin_id_t obj_builtin_id, /**< built-in ID */
ecma_object_t *obj_p = ecma_create_object (prototype_obj_p, ext_object_size, obj_type);
if (unlikely (!is_extensible))
if (JERRY_UNLIKELY (!is_extensible))
{
ecma_set_object_extensible (obj_p, false);
}