Implement Proxy object [[Get]] internal method (#3604)

The algorithm is based on ECMA-262 v6, 9.5.8 JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
2020-03-11 15:34:46 +01:00
parent 38862c39a6
commit 64fd37d1db
5 changed files with 188 additions and 26 deletions
@@ -414,8 +414,101 @@ ecma_proxy_object_get (ecma_object_t *obj_p, /**< proxy object */
                       ecma_value_t receiver) /**< receiver to invoke getter function */
 {
  JERRY_ASSERT (ECMA_OBJECT_IS_PROXY (obj_p));
-  JERRY_UNUSED_3 (obj_p, prop_name_p, receiver);
-  return ecma_raise_type_error (ECMA_ERR_MSG ("UNIMPLEMENTED: Proxy.[[Get]]"));
+
+  ecma_proxy_object_t *proxy_obj_p = (ecma_proxy_object_t *) obj_p;
+
+  /* 2. */
+  ecma_value_t handler = proxy_obj_p->handler;
+
+  /* 3. */
+  if (ecma_is_value_null (handler))
+  {
+    return ecma_raise_type_error (ECMA_ERR_MSG ("Handler can not be null."));
+  }
+
+  /* 4. */
+  JERRY_ASSERT (ecma_is_value_object (handler));
+
+  /* 5. */
+  ecma_value_t target = proxy_obj_p->target;
+
+  /* 6. */
+  ecma_value_t trap = ecma_op_get_method_by_magic_id (handler, LIT_MAGIC_STRING_GET);
+
+  /* 7. */
+  if (ECMA_IS_VALUE_ERROR (trap))
+  {
+    return trap;
+  }
+
+  ecma_object_t *target_obj_p = ecma_get_object_from_value (target);
+
+  /* 8. */
+  if (ecma_is_value_undefined (trap))
+  {
+    return ecma_op_object_get_with_receiver (target_obj_p, prop_name_p, receiver);
+  }
+
+  ecma_object_t *func_obj_p = ecma_get_object_from_value (trap);
+  ecma_value_t prop_value = ecma_make_prop_name_value (prop_name_p);
+  ecma_value_t args[] = { target, prop_value, receiver };
+
+  /* 9. */
+  ecma_value_t trap_result = ecma_op_function_call (func_obj_p, handler, args, 3);
+
+  ecma_deref_object (func_obj_p);
+
+  /* 10. */
+  if (ECMA_IS_VALUE_ERROR (trap_result))
+  {
+    return trap_result;
+  }
+
+  /* 11. */
+  ecma_property_descriptor_t target_desc;
+
+  ecma_value_t status = ecma_op_object_get_own_property_descriptor (target_obj_p, prop_name_p, &target_desc);
+
+  /* 12. */
+  if (ECMA_IS_VALUE_ERROR (status))
+  {
+    return status;
+  }
+
+  /* 13. */
+  if (ecma_is_value_true (status))
+  {
+    ecma_value_t ret_value = ECMA_VALUE_EMPTY;
+
+    if ((target_desc.flags & ECMA_PROP_IS_VALUE_DEFINED)
+        && !(target_desc.flags & ECMA_PROP_IS_CONFIGURABLE)
+        && !(target_desc.flags & ECMA_PROP_IS_WRITABLE)
+        && !ecma_op_same_value (trap_result, target_desc.value))
+    {
+      ret_value = ecma_raise_type_error (ECMA_ERR_MSG ("given property is a read-only and non-configurable"
+                                                       " data property on the proxy target"));
+    }
+    else if (!(target_desc.flags & ECMA_PROP_IS_CONFIGURABLE)
+            && (target_desc.flags & (ECMA_PROP_IS_GET_DEFINED | ECMA_PROP_IS_SET_DEFINED))
+            && target_desc.get_p == NULL
+            && !ecma_is_value_undefined (trap_result))
+    {
+      ret_value = ecma_raise_type_error (ECMA_ERR_MSG ("given property is a non-configurable property and"
+                                                       " does not have a getter function"));
+    }
+
+    ecma_free_property_descriptor (&target_desc);
+
+    if (ECMA_IS_VALUE_ERROR (ret_value))
+    {
+      ecma_free_value (trap_result);
+
+      return ret_value;
+    }
+  }
+
+  /* 14. */
+  return trap_result;
 } /* ecma_proxy_object_get */

 /**