Fix super property assignment for namedaccessor properties (#3654)
Tha patch also updates the [[Put]] internal method with the new steps from the ES6 standard. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
This commit is contained in:
@@ -43,7 +43,7 @@ assert(monster.foo === "foo");
|
||||
var target = { foo: "foo"};
|
||||
var handler = {
|
||||
set: function(obj, prop, value) {
|
||||
obj[prop] = "";
|
||||
obj[prop] = "";
|
||||
}
|
||||
};
|
||||
var proxy = new Proxy(target, handler);
|
||||
@@ -58,6 +58,7 @@ var handler = {};
|
||||
var proxy = new Proxy(target, handler);
|
||||
|
||||
// test when property does not exist on target
|
||||
/* TODO: Enable these tests when Proxy.[[GetOwnProperty]] has been implemented
|
||||
for (var p of properties) {
|
||||
proxy.p = 42;
|
||||
assert(target.p === 42);
|
||||
@@ -73,7 +74,7 @@ for (var p of properties) {
|
||||
proxy.p = 42;
|
||||
assert(target.p === 42);
|
||||
}
|
||||
|
||||
*/
|
||||
// test when target is a proxy
|
||||
var target = {};
|
||||
var handler = {
|
||||
|
||||
@@ -0,0 +1,75 @@
|
||||
// Copyright JS Foundation and other contributors, http://js.foundation
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
var setterCalled = false;
|
||||
|
||||
class Base {
|
||||
func () {
|
||||
return 5;
|
||||
}
|
||||
funcArrow () {
|
||||
return () => 5;
|
||||
}
|
||||
["com" + "puted"] () {
|
||||
return 10;
|
||||
}
|
||||
get getter () {
|
||||
return 6;
|
||||
}
|
||||
set setter (a) {
|
||||
setterCalled = true;
|
||||
}
|
||||
getSuperValueOf() {
|
||||
return super.valueOf;
|
||||
}
|
||||
}
|
||||
|
||||
class Derived extends Base {
|
||||
func () {
|
||||
return super.func();
|
||||
}
|
||||
funcArrow () {
|
||||
return () => super.func();
|
||||
}
|
||||
["com" + "puted"] () {
|
||||
return super["com" + "puted"]();
|
||||
}
|
||||
get getter () {
|
||||
return super.getter;
|
||||
}
|
||||
set setter (a) {
|
||||
super.setter = a;
|
||||
}
|
||||
deleteSuperReference () {
|
||||
delete super.a;
|
||||
}
|
||||
}
|
||||
|
||||
var derived = new Derived;
|
||||
var base = new Base;
|
||||
|
||||
assert (derived.func() === 5);
|
||||
assert (derived.funcArrow()() === 5);
|
||||
assert (derived.computed() === 10);
|
||||
assert (derived.getter === 6);
|
||||
derived.setter = 7;
|
||||
assert (setterCalled === true);
|
||||
assert (base.getSuperValueOf() === Object.prototype.valueOf);
|
||||
|
||||
try {
|
||||
derived.deleteSuperReference();
|
||||
assert (false);
|
||||
} catch (e) {
|
||||
assert (e instanceof ReferenceError);
|
||||
}
|
||||
Reference in New Issue
Block a user