YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix TypedArray.slice with external array buffer (#3080)

Browse Source 
In case of TypedArrays which were constructed with an ArrayBuffer
the `slice` method incorrectly added the `byteOffset` value of
when the elements were copied.

There is no need to add the `byteOffset` value for the ArrayBuffer's
contents pointer as it is already added by the `ecma_typedarray_get_buffer`
call.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
This commit is contained in:
Péter Gál
2019-09-07 12:22:20 +02:00
committed by Dániel Bátyai
parent 91818bea93
commit 5d51fe8f27
3 changed files with 93 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
+1 -2
View File
@@ -1967,8 +1967,7 @@ ecma_builtin_typedarray_prototype_slice (ecma_value_t this_arg, /**< this argume
ecma_object_t *new_typedarray_p = ecma_get_object_from_value (new_typedarray);
lit_utf8_byte_t *new_typedarray_buffer_p = ecma_typedarray_get_buffer (new_typedarray_p);
ecma_length_t src_byte_offset = ecma_typedarray_get_offset (typedarray_p);
uint32_t src_byte_index = (start * element_size) + src_byte_offset;
uint32_t src_byte_index = (start * element_size);
memcpy (new_typedarray_buffer_p,
typedarray_buffer_p + src_byte_index,