From 5cef002ed6f8f2ee81886f8cf083ac0c7b555e35 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Mon, 11 Jan 2021 18:48:53 +0100 Subject: [PATCH] Fix underscore lookahead in hex literal parsing (#4448) This patch fixes #4442. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- jerry-core/parser/js/js-lexer.c | 2 +- .../es.next/regression-test-issue-4442.js | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/es.next/regression-test-issue-4442.js diff --git a/jerry-core/parser/js/js-lexer.c b/jerry-core/parser/js/js-lexer.c index cffef9a4b..448cc8842 100644 --- a/jerry-core/parser/js/js-lexer.c +++ b/jerry-core/parser/js/js-lexer.c @@ -1393,7 +1393,7 @@ lexer_parse_number (parser_context_t *context_p) /**< context */ if (source_p < source_end_p && source_p[0] == LIT_CHAR_UNDERSCORE) { source_p++; - if (!lit_char_is_hex_digit (source_p[0]) || source_p == source_end_p) + if (source_p == source_end_p || !lit_char_is_hex_digit (source_p[0])) { parser_raise_error (context_p, PARSER_ERR_INVALID_UNDERSCORE_IN_NUMBER); } diff --git a/tests/jerry/es.next/regression-test-issue-4442.js b/tests/jerry/es.next/regression-test-issue-4442.js new file mode 100644 index 000000000..84d7fcbbb --- /dev/null +++ b/tests/jerry/es.next/regression-test-issue-4442.js @@ -0,0 +1,20 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +try { + eval('0x1_'); + assert(false); +} catch (e) { + assert(e instanceof SyntaxError); +}