From 58a649ffe8b85e79f16b3ac618bd0598c1b5a470 Mon Sep 17 00:00:00 2001 From: kisbg Date: Fri, 7 Aug 2020 14:34:57 +0200 Subject: [PATCH] Fixed Array.prototype.concat error type (#4117) JerryScript-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu --- jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c | 2 +- tests/jerry/es.next/to-length.js | 4 ++-- tests/test262-esnext-excludelist.xml | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c b/jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c index 92eb514be..b58a24015 100644 --- a/jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c +++ b/jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c @@ -359,7 +359,7 @@ ecma_builtin_helper_array_concat_value (ecma_object_t *array_obj_p, /**< array * /* 4 . */ if (*length_p + arg_len > ECMA_NUMBER_MAX_SAFE_INTEGER) { - return ecma_raise_range_error (ECMA_ERR_MSG ("Invalid array length.")); + return ecma_raise_type_error (ECMA_ERR_MSG ("Invalid array length.")); } #else /* !ENABLED (JERRY_ESNEXT) */ /* 5.b.ii */ diff --git a/tests/jerry/es.next/to-length.js b/tests/jerry/es.next/to-length.js index b5e962b19..f6645f7f7 100644 --- a/tests/jerry/es.next/to-length.js +++ b/tests/jerry/es.next/to-length.js @@ -31,14 +31,14 @@ function compareArray(a, b) { Array.prototype.concat.call({}, {[Symbol.isConcatSpreadable]: true, length : 2 **53 - 1}) assert(false); } catch (e) { - assert(e instanceof RangeError); + assert(e instanceof TypeError); } try { Array.prototype.concat.call([1, 2, 3, 4], {[Symbol.isConcatSpreadable]: true, length : 2 **53 - 4}) assert(false); } catch (e) { - assert(e instanceof RangeError); + assert(e instanceof TypeError); } })(); diff --git a/tests/test262-esnext-excludelist.xml b/tests/test262-esnext-excludelist.xml index 03870dee8..0b15c7565 100644 --- a/tests/test262-esnext-excludelist.xml +++ b/tests/test262-esnext-excludelist.xml @@ -152,7 +152,6 @@ -