YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove comparison of unused instruction operands fields (the fields could be uninitialized).

Browse Source 
Related issue: #585

JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
This commit is contained in:
Ruben Ayrapetyan
2015-08-18 12:39:22 +03:00
parent 5b9ce05491
commit 589ebb1802
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test-parser.cpp
+15 -1
View File
@@ -23,10 +23,24 @@
static bool static bool
instrs_equal (const vm_instr_t *instrs1, vm_instr_t *instrs2, uint16_t size) instrs_equal (const vm_instr_t *instrs1, vm_instr_t *instrs2, uint16_t size)
{ {
static const uint8_t instr_fields_num[] =
{
#define VM_OP_0(opcode_name, opcode_name_uppercase) \
1,
#define VM_OP_1(opcode_name, opcode_name_uppercase, arg1, arg1_type) \
2,
#define VM_OP_2(opcode_name, opcode_name_uppercase, arg1, arg1_type, arg2, arg2_type) \
3,
#define VM_OP_3(opcode_name, opcode_name_uppercase, arg1, arg1_type, arg2, arg2_type, arg3, arg3_type) \
4,
#include "vm-opcodes.inc.h"
};
uint16_t i; uint16_t i;
for (i = 0; i < size; i++) for (i = 0; i < size; i++)
{ {
if (memcmp (&instrs1[i], &instrs2[i], sizeof (vm_instr_t)) != 0) if (memcmp (&instrs1[i], &instrs2[i], instr_fields_num[instrs1[i].op_idx] * sizeof (idx_t)) != 0)
{ {
return false; return false;
} }