YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix define_own_property_descriptor to set configurable flag correctly (#3877)

Browse Source 
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs@inf.u-szeged.hu
This commit is contained in:
Roland Takacs
2020-06-08 18:12:39 +02:00
committed by GitHub
parent 36bf1ec09d
commit 585332f072
2 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/api/jerry.c
+2 -2
View File
@@ -2582,8 +2582,8 @@ jerry_define_own_property (const jerry_value_t obj_val, /**< object value */
if (prop_desc_p->is_configurable_defined) if (prop_desc_p->is_configurable_defined)
{ {
flags |= (uint32_t) (ECMA_PROP_IS_CONFIGURABLE_DEFINED | (prop_desc_p->is_enumerable ? ECMA_PROP_IS_CONFIGURABLE flags |= (uint32_t) (ECMA_PROP_IS_CONFIGURABLE_DEFINED | (prop_desc_p->is_configurable ? ECMA_PROP_IS_CONFIGURABLE
: ECMA_PROP_NO_OPTS)); : ECMA_PROP_NO_OPTS));
} }
/* Copy data property info. */ /* Copy data property info. */
tests/unit-core/test-api-property.c
+18 -1
View File
@@ -64,7 +64,6 @@ main (void)
TEST_ASSERT (jerry_value_is_undefined (prop_desc.getter)); TEST_ASSERT (jerry_value_is_undefined (prop_desc.getter));
TEST_ASSERT (prop_desc.is_set_defined == false); TEST_ASSERT (prop_desc.is_set_defined == false);
TEST_ASSERT (jerry_value_is_undefined (prop_desc.setter)); TEST_ASSERT (jerry_value_is_undefined (prop_desc.setter));
jerry_release_value (global_obj_val);
jerry_free_property_descriptor_fields (&prop_desc); jerry_free_property_descriptor_fields (&prop_desc);
if (jerry_is_feature_enabled (JERRY_FEATURE_PROXY)) if (jerry_is_feature_enabled (JERRY_FEATURE_PROXY))
@@ -83,6 +82,24 @@ main (void)
jerry_release_value (prop_name); jerry_release_value (prop_name);
/* Test: define and get own property descriptor */
prop_desc.is_enumerable = true;
prop_name = jerry_create_string ((const jerry_char_t *) "enumerable-property");
res = jerry_define_own_property (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (!jerry_value_is_error (res));
TEST_ASSERT (jerry_value_is_boolean (res));
TEST_ASSERT (jerry_get_boolean_value (res));
jerry_release_value (res);
jerry_free_property_descriptor_fields (&prop_desc);
is_ok = jerry_get_own_property_descriptor (global_obj_val, prop_name, &prop_desc);
TEST_ASSERT (is_ok);
TEST_ASSERT (prop_desc.is_writable == false);
TEST_ASSERT (prop_desc.is_enumerable == true);
TEST_ASSERT (prop_desc.is_configurable == false);
jerry_release_value (prop_name);
jerry_release_value (global_obj_val);
jerry_cleanup (); jerry_cleanup ();
return 0; return 0;