YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing [[DefineOwnProperty]]: correctly setting up value of data named property; correctly increasing reference counters of getter and setter.

Browse Source
This commit is contained in:
Ruben Ayrapetyan
2014-07-30 18:24:14 +04:00
parent df224408fc
commit 45a3d52d70
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libecmaoperations/ecma-objects-properties.c
+18 -5
View File
@@ -14,6 +14,7 @@
*/ */
#include "ecma-exceptions.h" #include "ecma-exceptions.h"
#include "ecma-gc.h"
#include "ecma-globals.h" #include "ecma-globals.h"
#include "ecma-helpers.h" #include "ecma-helpers.h"
#include "ecma-objects-properties.h" #include "ecma-objects-properties.h"
@@ -546,17 +547,29 @@ ecma_op_object_define_own_property( ecma_object_t *obj_p, /**< the object */
if ( is_property_desc_generic_descriptor if ( is_property_desc_generic_descriptor
|| is_property_desc_data_descriptor ) || is_property_desc_data_descriptor )
{ {
ecma_create_named_data_property( obj_p, ecma_property_t *new_prop_p = ecma_create_named_data_property( obj_p,
property_name_p, property_name_p,
property_desc.writable, property_desc.writable,
property_desc.enumerable, property_desc.enumerable,
property_desc.configurable); property_desc.configurable);
new_prop_p->u.named_data_property.value = ecma_copy_value( property_desc.value);
} }
else else
{ {
// b. // b.
JERRY_ASSERT( is_property_desc_accessor_descriptor ); JERRY_ASSERT( is_property_desc_accessor_descriptor );
if ( property_desc.get_p != NULL )
{
ecma_ref_object( property_desc.get_p);
}
if ( property_desc.set_p != NULL )
{
ecma_ref_object( property_desc.set_p);
}
ecma_create_named_accessor_property( obj_p, ecma_create_named_accessor_property( obj_p,
property_name_p, property_name_p,
property_desc.get_p, property_desc.get_p,