From 448c239f08d8d81270307f0afe7a5984cf960cb8 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Mon, 28 Oct 2019 15:30:47 +0100 Subject: [PATCH] Export statement parsing should construct new ident literal (#3256) This patch fixes #3253. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- jerry-core/parser/js/js-parser-module.c | 4 ++-- tests/jerry/fail/regression-test-issue-3253-1.js | 16 ++++++++++++++++ tests/jerry/fail/regression-test-issue-3253-2.js | 16 ++++++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 tests/jerry/fail/regression-test-issue-3253-1.js create mode 100644 tests/jerry/fail/regression-test-issue-3253-2.js diff --git a/jerry-core/parser/js/js-parser-module.c b/jerry-core/parser/js/js-parser-module.c index da5ebe061..812e8896d 100644 --- a/jerry-core/parser/js/js-parser-module.c +++ b/jerry-core/parser/js/js-parser-module.c @@ -347,7 +347,7 @@ parser_module_parse_export_clause (parser_context_t *context_p) /**< parser cont ecma_string_t *export_name_p = NULL; ecma_string_t *local_name_p = NULL; - lexer_construct_literal_object (context_p, &context_p->token.lit_location, LEXER_IDENT_LITERAL); + lexer_construct_literal_object (context_p, &context_p->token.lit_location, LEXER_NEW_IDENT_LITERAL); uint16_t local_name_index = context_p->lit_object.index; uint16_t export_name_index = PARSER_MAXIMUM_NUMBER_OF_LITERALS; @@ -363,7 +363,7 @@ parser_module_parse_export_clause (parser_context_t *context_p) /**< parser cont parser_raise_error (context_p, PARSER_ERR_IDENTIFIER_EXPECTED); } - lexer_construct_literal_object (context_p, &context_p->token.lit_location, LEXER_IDENT_LITERAL); + lexer_construct_literal_object (context_p, &context_p->token.lit_location, LEXER_NEW_IDENT_LITERAL); export_name_index = context_p->lit_object.index; diff --git a/tests/jerry/fail/regression-test-issue-3253-1.js b/tests/jerry/fail/regression-test-issue-3253-1.js new file mode 100644 index 000000000..299cdb939 --- /dev/null +++ b/tests/jerry/fail/regression-test-issue-3253-1.js @@ -0,0 +1,16 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +var a; +export { a diff --git a/tests/jerry/fail/regression-test-issue-3253-2.js b/tests/jerry/fail/regression-test-issue-3253-2.js new file mode 100644 index 000000000..2f8c563ab --- /dev/null +++ b/tests/jerry/fail/regression-test-issue-3253-2.js @@ -0,0 +1,16 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +var a, b; +export { a as b