Accessors should be kept alive during their invocation (#5167)

This patch fixes #4900.

The implementation is based on PR #4943, only resolved the conflicts.

Co-authored-by: Robert Fancsik robert.fancsik@h-lab.eu
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
This commit is contained in:
Gergo Csizi
2024-11-18 09:47:07 +01:00
committed by GitHub
parent 38e05b4569
commit 348e6a470e
6 changed files with 104 additions and 38 deletions
@@ -1359,6 +1359,55 @@ ecma_op_function_call_bound (ecma_object_t *func_obj_p, /**< Function object */
return ret_value;
} /* ecma_op_function_call_bound */
/**
* Invoke accessor getter function
*
* @return ecma value
* Returned value must be freed with ecma_free_value
*/
extern inline ecma_value_t JERRY_ATTR_ALWAYS_INLINE
ecma_op_invoke_getter (ecma_getter_setter_pointers_t *get_set_pair_p, /**< accessor pair */
ecma_value_t this_value) /**< 'this' argument's value */
{
if (get_set_pair_p->getter_cp == JMEM_CP_NULL)
{
return ECMA_VALUE_UNDEFINED;
}
ecma_object_t *getter_p = ECMA_GET_NON_NULL_POINTER (ecma_object_t, get_set_pair_p->getter_cp);
ecma_ref_object (getter_p);
ecma_value_t result = ecma_op_function_call (getter_p, this_value, NULL, 0);
ecma_deref_object (getter_p);
return result;
} /* ecma_op_invoke_getter */
/**
* Invoke accessor setter function
*
* @return ecma value
* Returned value must be freed with ecma_free_value
*/
extern inline ecma_value_t JERRY_ATTR_ALWAYS_INLINE
ecma_op_invoke_setter (ecma_getter_setter_pointers_t *get_set_pair_p, /**< accessor pair */
ecma_value_t this_value, /**< 'this' argument's value */
ecma_value_t value) /**< value to set */
{
if (get_set_pair_p->setter_cp == JMEM_CP_NULL)
{
return ecma_raise_type_error (ECMA_ERR_PRIVATE_FIELD_WAS_DEFINED_WITHOUT_A_SETTER);
}
ecma_object_t *setter_p = ECMA_GET_NON_NULL_POINTER (ecma_object_t, get_set_pair_p->setter_cp);
ecma_ref_object (setter_p);
ecma_value_t result = ecma_op_function_call (setter_p, this_value, &value, 1);
ecma_deref_object (setter_p);
return result;
} /* ecma_op_invoke_setter */
/**
* General [[Call]] implementation
*