From 2dd854d28ba381846980665256b941e569d4c85d Mon Sep 17 00:00:00 2001
From: Robert Fancsik <frobert@inf.u-szeged.hu>
Date: Thu, 7 Feb 2019 16:07:35 +0100
Subject: [PATCH] Ensure that ecma_get_number throws error for symbol values.
 (#2744)

This patch fixes #2743.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
---
 jerry-core/ecma/operations/ecma-conversion.c  |  7 ++++++
 .../es2015/regression-test-issue-2743.js      | 24 +++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 tests/jerry/es2015/regression-test-issue-2743.js

diff --git a/jerry-core/ecma/operations/ecma-conversion.c b/jerry-core/ecma/operations/ecma-conversion.c
index 4441f4296..9560e0329 100644
--- a/jerry-core/ecma/operations/ecma-conversion.c
+++ b/jerry-core/ecma/operations/ecma-conversion.c
@@ -360,6 +360,13 @@ ecma_get_number (ecma_value_t value, /**< ecma value*/
     return ECMA_VALUE_EMPTY;
   }
 
+#ifndef CONFIG_DISABLE_ES2015_SYMBOL_BUILTIN
+  if (ecma_is_value_symbol (value))
+  {
+    return ecma_raise_type_error (ECMA_ERR_MSG ("Cannot convert a Symbol value to a number."));
+  }
+#endif /* !CONFIG_DISABLE_ES2015_SYMBOL_BUILTIN */
+
   JERRY_ASSERT (ecma_is_value_boolean (value));
 
   *number_p = ecma_is_value_true (value) ? 1 : 0;
diff --git a/tests/jerry/es2015/regression-test-issue-2743.js b/tests/jerry/es2015/regression-test-issue-2743.js
new file mode 100644
index 000000000..455a99b7c
--- /dev/null
+++ b/tests/jerry/es2015/regression-test-issue-2743.js
@@ -0,0 +1,24 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+var v1 = Object(Symbol("symbol"))
+var v2 = new RegExp();
+var v3 = new Array(v1)
+
+try {
+  var v4 = v3.forEach(function(p_0, p_1, p_2) { return p_0 + p_1 + p_2; }, v2);
+  assert (false);
+} catch (e) {
+  assert (e instanceof TypeError);
+}